All of lore.kernel.org
 help / color / mirror / Atom feed
From: frank.blaschka@de.ibm.com
To: jgarzik@pobox.com
Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org
Subject: [patch 7/8] qeth: core code should alloc headroom for LLC protocol
Date: Tue, 01 Apr 2008 10:26:59 +0200	[thread overview]
Message-ID: <20080401082745.152557000@de.ibm.com> (raw)
In-Reply-To: 20080401082652.754871000@de.ibm.com

[-- Attachment #1: 07-qeth_headroom.patch --]
[-- Type: text/plain, Size: 1007 bytes --]

From: Frank Blaschka <frank.blaschka@de.ibm.com>

Allocate headroom for TR_HLEN but using only ETH_HLEN causes rx
performance degradation. Allocate ETH_HLEN for ethernet and
TR_HLEN for token ring (layer 3 mode).

Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com>
---
 drivers/s390/net/qeth_core_main.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Index: git_davem-2.6.26/drivers/s390/net/qeth_core_main.c
===================================================================
--- git_davem-2.6.26.orig/drivers/s390/net/qeth_core_main.c	2008-03-31 13:21:07.000000000 +0200
+++ git_davem-2.6.26/drivers/s390/net/qeth_core_main.c	2008-03-31 13:21:36.000000000 +0200
@@ -4002,7 +4002,11 @@
 		}
 	} else {
 		skb_len = (*hdr)->hdr.l3.length;
-		headroom = max((int)ETH_HLEN, (int)TR_HLEN);
+		if ((card->info.link_type == QETH_LINK_TYPE_LANE_TR) ||
+		    (card->info.link_type == QETH_LINK_TYPE_HSTR))
+			headroom = TR_HLEN;
+		else
+			headroom = ETH_HLEN;
 	}
 
 	if (!skb_len)

-- 

  parent reply	other threads:[~2008-04-01  8:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-01  8:26 [patch 0/8] s390: qeth bug fixes for 2.6.26 frank.blaschka
2008-04-01  8:26 ` [patch 1/8] qeth: improve ip_list administration after deregister failures frank.blaschka
2008-04-12  9:02   ` Jeff Garzik
2008-04-01  8:26 ` [patch 2/8] qeth: allow qdio queue element addresses > 2GB frank.blaschka
2008-04-01  8:26 ` [patch 3/8] qeth: set lan_online flag after a received STARTLAN frank.blaschka
2008-04-01  8:26 ` [patch 4/8] qeth: CCL-sequence numbers required for protocol ETH_P_802_2 only frank.blaschka
2008-04-01  8:26 ` [patch 6/8] qeth: improving debug message handling frank.blaschka
2008-04-01  8:26 ` frank.blaschka [this message]
2008-04-01  8:27 ` [patch 8/8] qeth: keep ip-address after LAN_OFFLINE failure frank.blaschka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080401082745.152557000@de.ibm.com \
    --to=frank.blaschka@de.ibm.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-s390@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.