From: frank.blaschka@de.ibm.com
To: jgarzik@pobox.com
Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org,
Ursula Braun <braunu@de.ibm.com>
Subject: [patch 8/8] qeth: keep ip-address after LAN_OFFLINE failure
Date: Tue, 01 Apr 2008 10:27:00 +0200 [thread overview]
Message-ID: <20080401082745.841399000@de.ibm.com> (raw)
In-Reply-To: 20080401082652.754871000@de.ibm.com
[-- Attachment #1: 08-qeth_lan_offline.patch --]
[-- Type: text/plain, Size: 1263 bytes --]
From: Ursula Braun <braunu@de.ibm.com>
Problem: If setting of an ip-address fails with LAN_OFFLINE,
qeth does not save the ip-address in its internal
list of set ip-addresses. qeth recovers after a
following STARTLAN event, but cannot set the unsaved
ip-address.
Solution: save the ip-address in the qeth-maintained list of
ip-addresses after a LAN_OFFLINE failure for SETIP.
Signed-off-by: Ursula Braun <braunu@de.ibm.com>
Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com>
---
drivers/s390/net/qeth_l3_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: git_davem-2.6.26/drivers/s390/net/qeth_l3_main.c
===================================================================
--- git_davem-2.6.26.orig/drivers/s390/net/qeth_l3_main.c 2008-03-31 13:21:04.000000000 +0200
+++ git_davem-2.6.26/drivers/s390/net/qeth_l3_main.c 2008-03-31 13:21:41.000000000 +0200
@@ -461,7 +461,7 @@
spin_unlock_irqrestore(&card->ip_lock, flags);
rc = qeth_l3_register_addr_entry(card, todo);
spin_lock_irqsave(&card->ip_lock, flags);
- if (!rc)
+ if (!rc || (rc == IPA_RC_LAN_OFFLINE))
list_add_tail(&todo->entry, &card->ip_list);
else
kfree(todo);
--
prev parent reply other threads:[~2008-04-01 8:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-01 8:26 [patch 0/8] s390: qeth bug fixes for 2.6.26 frank.blaschka
2008-04-01 8:26 ` [patch 1/8] qeth: improve ip_list administration after deregister failures frank.blaschka
2008-04-12 9:02 ` Jeff Garzik
2008-04-01 8:26 ` [patch 2/8] qeth: allow qdio queue element addresses > 2GB frank.blaschka
2008-04-01 8:26 ` [patch 3/8] qeth: set lan_online flag after a received STARTLAN frank.blaschka
2008-04-01 8:26 ` [patch 4/8] qeth: CCL-sequence numbers required for protocol ETH_P_802_2 only frank.blaschka
2008-04-01 8:26 ` [patch 6/8] qeth: improving debug message handling frank.blaschka
2008-04-01 8:26 ` [patch 7/8] qeth: core code should alloc headroom for LLC protocol frank.blaschka
2008-04-01 8:27 ` frank.blaschka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080401082745.841399000@de.ibm.com \
--to=frank.blaschka@de.ibm.com \
--cc=braunu@de.ibm.com \
--cc=jgarzik@pobox.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.