[PATCH] Fix xss1500 compilation

[PATCH] Fix xss1500 compilation

[Florian Fainelli]

This patch fixes the compilation of the Au1000 XSS1500
board setup and irqmap code.

Signed-off-by: Florian Fainelli <florian.fainelli@telecomint.eu>
---
diff --git a/arch/mips/au1000/xxs1500/board_setup.c 
b/arch/mips/au1000/xxs1500/board_setup.c
index a9237f4..b2e413e 100644
--- a/arch/mips/au1000/xxs1500/board_setup.c
+++ b/arch/mips/au1000/xxs1500/board_setup.c
@@ -33,11 +33,10 @@
 #include <asm/cpu.h>
 #include <asm/bootinfo.h>
 #include <asm/irq.h>
-#include <asm/keyboard.h>
 #include <asm/mipsregs.h>
 #include <asm/reboot.h>
 #include <asm/pgtable.h>
-#include <asm/au1000.h>
+#include <asm/mach-au1x00/au1000.h>
 
 void board_reset(void)
 {
diff --git a/arch/mips/au1000/xxs1500/irqmap.c 
b/arch/mips/au1000/xxs1500/irqmap.c
index 3893492..a343da1 100644
--- a/arch/mips/au1000/xxs1500/irqmap.c
+++ b/arch/mips/au1000/xxs1500/irqmap.c
@@ -45,7 +45,7 @@
 #include <asm/io.h>
 #include <asm/mipsregs.h>
 #include <asm/system.h>
-#include <asm/au1000.h>
+#include <asm/mach-au1x00/au1000.h>
 
 struct au1xxx_irqmap __initdata au1xxx_irq_map[] = {
 	{ AU1500_GPIO_204, INTC_INT_HIGH_LEVEL, 0},

Re: [PATCH] Fix xss1500 compilation

[Ralf Baechle]

On Tue, Apr 01, 2008 at 03:53:25PM +0200, Florian Fainelli wrote:

> This patch fixes the compilation of the Au1000 XSS1500
> board setup and irqmap code.

I'm okay with the patch this case raises the question how popular if at
all this platform still is ...

  Ralf

Re: [PATCH] Fix xss1500 compilation

[Adrian Bunk]

On Tue, Apr 01, 2008 at 03:53:25PM +0200, Florian Fainelli wrote:
> This patch fixes the compilation of the Au1000 XSS1500
> board setup and irqmap code.
>...

Another compile error for this platform is:

<--  snip  -->

...
  CC [M]  drivers/pcmcia/au1000_xxs1500.o
/tmp/linux-2.6.25-rc7/drivers/pcmcia/au1000_xxs1500.c:33:26: error: linux/tqueue.h: No such file or directory
/tmp/linux-2.6.25-rc7/drivers/pcmcia/au1000_xxs1500.c:44:28: error: pcmcia/bus_ops.h: No such file or directory
/tmp/linux-2.6.25-rc7/drivers/pcmcia/au1000_xxs1500.c:51:24: error: asm/au1000.h: No such file or directory
/tmp/linux-2.6.25-rc7/drivers/pcmcia/au1000_xxs1500.c:52:31: error: asm/au1000_pcmcia.h: No such file or directory
...
make[3]: *** [drivers/pcmcia/au1000_xxs1500.o] Error 1

<--  snip  -->

include/linux/tqueue.h was removed on Sep 30, 2002 (sic) which was even 
before 2.6.0 .

Obviously no 2.6 kernel ever ran on these boards.

If you have such a board and want to run kernel 2.6 on it that's fine 
with me, but otherwise i don't see much point in keeping the support 
for this board.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [PATCH] Fix xss1500 compilation

[Sergei Shtylyov]

Adrian Bunk wrote:

>>This patch fixes the compilation of the Au1000 XSS1500
>>board setup and irqmap code.
>>...

> Another compile error for this platform is:
> 
> <--  snip  -->

> ...
>   CC [M]  drivers/pcmcia/au1000_xxs1500.o
> /tmp/linux-2.6.25-rc7/drivers/pcmcia/au1000_xxs1500.c:33:26: error: linux/tqueue.h: No such file or directory
> /tmp/linux-2.6.25-rc7/drivers/pcmcia/au1000_xxs1500.c:44:28: error: pcmcia/bus_ops.h: No such file or directory
> /tmp/linux-2.6.25-rc7/drivers/pcmcia/au1000_xxs1500.c:51:24: error: asm/au1000.h: No such file or directory
> /tmp/linux-2.6.25-rc7/drivers/pcmcia/au1000_xxs1500.c:52:31: error: asm/au1000_pcmcia.h: No such file or directory
> ...
> make[3]: *** [drivers/pcmcia/au1000_xxs1500.o] Error 1

> <--  snip  -->

> include/linux/tqueue.h was removed on Sep 30, 2002 (sic) which was even 
> before 2.6.0 .

> Obviously no 2.6 kernel ever ran on these boards.

    Not true -- there have been 2.6 patches from MyCable, the board vendor.
According to them, the last version supported version (on request) was 2.6.22.

WBR, Sergei

Re: [PATCH] Fix xss1500 compilation

[Adrian Bunk]

On Tue, Apr 01, 2008 at 08:16:39PM +0400, Sergei Shtylyov wrote:
> Adrian Bunk wrote:
>
>>> This patch fixes the compilation of the Au1000 XSS1500
>>> board setup and irqmap code.
>>> ...
>
>> Another compile error for this platform is:
>>
>> <--  snip  -->
>
>> ...
>>   CC [M]  drivers/pcmcia/au1000_xxs1500.o
>> /tmp/linux-2.6.25-rc7/drivers/pcmcia/au1000_xxs1500.c:33:26: error: linux/tqueue.h: No such file or directory
>> /tmp/linux-2.6.25-rc7/drivers/pcmcia/au1000_xxs1500.c:44:28: error: pcmcia/bus_ops.h: No such file or directory
>> /tmp/linux-2.6.25-rc7/drivers/pcmcia/au1000_xxs1500.c:51:24: error: asm/au1000.h: No such file or directory
>> /tmp/linux-2.6.25-rc7/drivers/pcmcia/au1000_xxs1500.c:52:31: error: asm/au1000_pcmcia.h: No such file or directory
>> ...
>> make[3]: *** [drivers/pcmcia/au1000_xxs1500.o] Error 1
>
>> <--  snip  -->
>
>> include/linux/tqueue.h was removed on Sep 30, 2002 (sic) which was even 
>> before 2.6.0 .
>
>> Obviously no 2.6 kernel ever ran on these boards.
>
>    Not true -- there have been 2.6 patches from MyCable, the board vendor.

When I talk about a "2.6 kernel" I'm talking about what is on
ftp.kernel.org, not what is hidden in some vendor patches.

> According to them, the last version supported version (on request) was 2.6.22.

Why is it not being submitted, and how much does it actually have in 
common with the code currently in the kernel?

After all, e.g. the pcmcia driver was added in 2003 with the
#include <linux/tqueue.h> and a "Copyright 2003 MontaVista Software Inc.".

And 2003 is one year *after* include/linux/tqueue.h was removed.

If MyCable submits their patches for 2.6.22 (adapted to 2.6.25 if 
required) that would be great.

But otherwise there's simply no point in trying to fix the compilation 
of this kernel 2.4 code that was dumped into kernel 2.6.

> WBR, Sergei

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

RE: [PATCH] Fix xss1500 compilation

[Nico Coesel]

I just looked at some other AU1x00 PCMCIA drivers. My guess is that if
someone wants to use PCMCIA on the XXS1500 board it is pretty simple to
create a new driver based on the pb1x00 or db1x00 board drivers
-assuming these work and compile well-.

Nico Coesel

> -----Oorspronkelijk bericht-----
> Van: linux-mips-bounce@linux-mips.org 
> [mailto:linux-mips-bounce@linux-mips.org] Namens Adrian Bunk
> Verzonden: dinsdag 1 april 2008 17:55
> Aan: Florian Fainelli
> CC: linux-mips@linux-mips.org; ralf@linux-mips.org
> Onderwerp: Re: [PATCH] Fix xss1500 compilation
> 
> On Tue, Apr 01, 2008 at 03:53:25PM +0200, Florian Fainelli wrote:
> > This patch fixes the compilation of the Au1000 XSS1500  board setup 
> >and irqmap code.
> >...
> 
> Another compile error for this platform is:
> 
> <--  snip  -->
> 
> ...
>   CC [M]  drivers/pcmcia/au1000_xxs1500.o
> /tmp/linux-2.6.25-rc7/drivers/pcmcia/au1000_xxs1500.c:33:26: 
> error: linux/tqueue.h: No such file or directory
> /tmp/linux-2.6.25-rc7/drivers/pcmcia/au1000_xxs1500.c:44:28: 
> error: pcmcia/bus_ops.h: No such file or directory
> /tmp/linux-2.6.25-rc7/drivers/pcmcia/au1000_xxs1500.c:51:24: 
> error: asm/au1000.h: No such file or directory
> /tmp/linux-2.6.25-rc7/drivers/pcmcia/au1000_xxs1500.c:52:31: 
> error: asm/au1000_pcmcia.h: No such file or directory ...
> make[3]: *** [drivers/pcmcia/au1000_xxs1500.o] Error 1
> 
> <--  snip  -->
> 
> include/linux/tqueue.h was removed on Sep 30, 2002 (sic) 
> which was even before 2.6.0 .
> 
> Obviously no 2.6 kernel ever ran on these boards.
> 
> If you have such a board and want to run kernel 2.6 on it 
> that's fine with me, but otherwise i don't see much point in 
> keeping the support for this board.
> 
> cu
> Adrian
> 
> -- 
> 
>        "Is there not promise of rain?" Ling Tan asked suddenly out
>         of the darkness. There had been need of rain for many days.
>        "Only a promise," Lao Er said.
>                                        Pearl S. Buck - Dragon Seed
> 
> 
> 

RE: [PATCH] Fix xss1500 compilation

[Nico Coesel]

I just looked at some other AU1x00 PCMCIA drivers. My guess is that if
someone wants to use PCMCIA on the XXS1500 board it is pretty simple to
create a new driver based on the pb1x00 or db1x00 board drivers
-assuming these work and compile well-.

Nico Coesel

> -----Oorspronkelijk bericht-----
> Van: linux-mips-bounce@linux-mips.org 
> [mailto:linux-mips-bounce@linux-mips.org] Namens Adrian Bunk
> Verzonden: dinsdag 1 april 2008 17:55
> Aan: Florian Fainelli
> CC: linux-mips@linux-mips.org; ralf@linux-mips.org
> Onderwerp: Re: [PATCH] Fix xss1500 compilation
> 
> On Tue, Apr 01, 2008 at 03:53:25PM +0200, Florian Fainelli wrote:
> > This patch fixes the compilation of the Au1000 XSS1500  board setup 
> >and irqmap code.
> >...
> 
> Another compile error for this platform is:
> 
> <--  snip  -->
> 
> ...
>   CC [M]  drivers/pcmcia/au1000_xxs1500.o
> /tmp/linux-2.6.25-rc7/drivers/pcmcia/au1000_xxs1500.c:33:26: 
> error: linux/tqueue.h: No such file or directory
> /tmp/linux-2.6.25-rc7/drivers/pcmcia/au1000_xxs1500.c:44:28: 
> error: pcmcia/bus_ops.h: No such file or directory
> /tmp/linux-2.6.25-rc7/drivers/pcmcia/au1000_xxs1500.c:51:24: 
> error: asm/au1000.h: No such file or directory
> /tmp/linux-2.6.25-rc7/drivers/pcmcia/au1000_xxs1500.c:52:31: 
> error: asm/au1000_pcmcia.h: No such file or directory ...
> make[3]: *** [drivers/pcmcia/au1000_xxs1500.o] Error 1
> 
> <--  snip  -->
> 
> include/linux/tqueue.h was removed on Sep 30, 2002 (sic) 
> which was even before 2.6.0 .
> 
> Obviously no 2.6 kernel ever ran on these boards.
> 
> If you have such a board and want to run kernel 2.6 on it 
> that's fine with me, but otherwise i don't see much point in 
> keeping the support for this board.
> 
> cu
> Adrian
> 
> -- 
> 
>        "Is there not promise of rain?" Ling Tan asked suddenly out
>         of the darkness. There had been need of rain for many days.
>        "Only a promise," Lao Er said.
>                                        Pearl S. Buck - Dragon Seed
> 
> 
>