From: Samuel Thibault <samuel.thibault@eu.citrix.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: INAKOSHI Hiroya <inakoshi.hiroya@jp.fujitsu.com>,
xen-devel@lists.xensource.com
Subject: Re: [PATCH] incorrect xfree for mini-os
Date: Wed, 2 Apr 2008 23:40:27 +0200 [thread overview]
Message-ID: <20080402214027.GB6212@implementation> (raw)
In-Reply-To: <C4195AA7.1EB5F%keir.fraser@eu.citrix.com>
Keir Fraser, le Wed 02 Apr 2008 15:45:43 +0100, a écrit :
> On 2/4/08 11:52, "Samuel Thibault" <samuel.thibault@eu.citrix.com> wrote:
>
> > INAKOSHI Hiroya, le Wed 02 Apr 2008 19:43:29 +0900, a écrit :
> >> xfree in extras/mini-os/lib/xmalloc.c is incorrect.
> >>
> >> It has to check first if the memory to free is so big as to be freed
> >> directly by free_pages.
> >>
> >> mini-os domains crash without this patch if they don't configure vfb
> >> correctly.
> >>
> >> Signed-off-by: INAKOSHI Hiroya <inakoshi.hiroya@jp.fujitsu.com>
> >
> > Acked-by: Samuel Thibault <samuel.thibault@eu.citrix.com>
>
> Applied, but shouldn't the checks that this patch skips work okay even for
> big allocations made via xmalloc_whole_pages()?
The "hdr will be on same page" will typically not work when aligning the
big area on pages.
Samuel
prev parent reply other threads:[~2008-04-02 21:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-02 10:43 [PATCH] incorrect xfree for mini-os INAKOSHI Hiroya
2008-04-02 10:52 ` Samuel Thibault
2008-04-02 14:45 ` Keir Fraser
2008-04-02 21:40 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080402214027.GB6212@implementation \
--to=samuel.thibault@eu.citrix.com \
--cc=inakoshi.hiroya@jp.fujitsu.com \
--cc=keir.fraser@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.