From: Stefan Roese <sr@denx.de>
To: benh@kernel.crashing.org
Cc: netdev@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] ibm_newemac: Add support for 460EX/GT-type MAL rx-channel handling
Date: Thu, 3 Apr 2008 14:35:39 +0200 [thread overview]
Message-ID: <200804031435.39999.sr@denx.de> (raw)
In-Reply-To: <1207225740.10388.321.camel@pasglop>
On Thursday 03 April 2008, Benjamin Herrenschmidt wrote:
> On Thu, 2008-04-03 at 13:45 +0200, Stefan Roese wrote:
> > On some 4xx PPC's (e.g. 460EX/GT), the rx channel number is a multiple
> > of 8 (e.g. 8 for EMAC1, 16 for EMAC2), but enabling in MAL_RXCASR needs
> > the divided by 8 value for the bitmask.
>
> Sounds ok, but I wonder if we ever have a MAL with more than 8 chans, do
> we need to make this shift conditional to some device tree prop ?
I suggest we postpone such a conditional setup until we see such a MAL. OK?
Best regards,
Stefan
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Roese <sr@denx.de>
To: benh@kernel.crashing.org
Cc: netdev@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] ibm_newemac: Add support for 460EX/GT-type MAL rx-channel handling
Date: Thu, 3 Apr 2008 14:35:39 +0200 [thread overview]
Message-ID: <200804031435.39999.sr@denx.de> (raw)
In-Reply-To: <1207225740.10388.321.camel@pasglop>
On Thursday 03 April 2008, Benjamin Herrenschmidt wrote:
> On Thu, 2008-04-03 at 13:45 +0200, Stefan Roese wrote:
> > On some 4xx PPC's (e.g. 460EX/GT), the rx channel number is a multiple
> > of 8 (e.g. 8 for EMAC1, 16 for EMAC2), but enabling in MAL_RXCASR needs
> > the divided by 8 value for the bitmask.
>
> Sounds ok, but I wonder if we ever have a MAL with more than 8 chans, do
> we need to make this shift conditional to some device tree prop ?
I suggest we postpone such a conditional setup until we see such a MAL. OK?
Best regards,
Stefan
next prev parent reply other threads:[~2008-04-03 12:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-03 11:45 [PATCH] ibm_newemac: Add support for 460EX/GT-type MAL rx-channel handling Stefan Roese
2008-04-03 11:45 ` Stefan Roese
2008-04-03 12:29 ` Benjamin Herrenschmidt
2008-04-03 12:35 ` Stefan Roese [this message]
2008-04-03 12:35 ` Stefan Roese
2008-04-03 13:10 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804031435.39999.sr@denx.de \
--to=sr@denx.de \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.