All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@eu.citrix.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: Re: [Xen-changelog] [xen-unstable] Clean up handling of IS_PRIV_FOR() and rcu_[un]lock_domain().
Date: Sat, 5 Apr 2008 16:28:14 +0200	[thread overview]
Message-ID: <20080405142814.GL4005@implementation> (raw)
In-Reply-To: <C413DCED.1587C%keir.fraser@eu.citrix.com>

Hello,

Keir Fraser, le Sat 29 Mar 2008 11:47:57 +0000, a écrit :
> > IIRC the event channel ops are not needed right now, but will probably
> > be in the future.
> 
> They were all fine, except there was one inexplicable check of IS_PRIV_FOR()
> in bind_interdomain() which I nuked. It was so bizarre that I assumed you
> must have put it there for a reason, and this would be one that you'd
> complain about.

I'm now complaining :)

The bind_interdomain() trick is needed for the ioreq events channel:
when it gets installed, it is supposed to be between the HVM domain and
dom0 (the stub domain doesn't exist anyway).  The meaning of the test is
hence to allow the stub domain to hijack that event channel (because it
has privileges on the remote domain).

With that fix, stub domains are working again (but Cirrus bios doesn't
work yet)

Samuel

  parent reply	other threads:[~2008-04-05 14:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200803290750.m2T7o8pP027589@xenbits.xensource.com>
2008-03-29 11:23 ` [Xen-changelog] [xen-unstable] Clean up handling of IS_PRIV_FOR() and rcu_[un]lock_domain() Samuel Thibault
2008-03-29 11:47   ` Keir Fraser
2008-03-29 11:58     ` Samuel Thibault
2008-04-05 14:28     ` Samuel Thibault [this message]
2008-04-05 16:31       ` Keir Fraser
2008-04-11 14:27         ` Samuel Thibault
2008-04-05 16:25     ` Samuel Thibault
2008-04-10 15:43     ` ioemu & settimeoffset [Was: Clean up handling of IS_PRIV_FOR() and rcu_[un]lock_domain()] Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080405142814.GL4005@implementation \
    --to=samuel.thibault@eu.citrix.com \
    --cc=keir.fraser@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.