Re: [PATCH][RFC] Supporting Enlightened Windows 2008Server

["Daniel P. Berrange" <berrange@redhat.com>]

On Fri, Apr 04, 2008 at 05:41:32PM -0600, Ky Srinivasan wrote:
> Based on the feedback I got from you and Tim, I am enclosing 
> the next version of the patches to support enlightened win2008
>  server. Here are the changes I have made:
> 
> 1) I have put the shim on a low calorie diet - I have gotten rid
>  of the framework infrastructure and to the extent possible 
>  integrated the shim code with xen.
> 
> 2) I have tried to cleanup the code. I am sure  more work will be 
> needed here.
> 
> 3) I am not advertising the TLB related enlightenments. We can 
> revisit this later if needed.


> Index: xen-unstable.hg/tools/python/xen/xm/create.py
> ===================================================================
> --- xen-unstable.hg.orig/tools/python/xen/xm/create.py	2008-04-04 13:01:01.000000000 -0400
> +++ xen-unstable.hg/tools/python/xen/xm/create.py	2008-04-04 13:45:08.000000000 -0400
> @@ -207,6 +207,10 @@
>            use="""Timer mode (0=delay virtual time when ticks are missed;
>            1=virtual time is always wallclock time.""")
>  
> +gopts.var('extid', val='EXTID',
> +          fn=set_int, default=0,
> +          use="Specify extention ID for a HVM domain.")
> +
>  gopts.var('acpi', val='ACPI',
>            fn=set_int, default=1,
>            use="Disable or enable ACPI of HVM domain.")
> @@ -750,7 +754,7 @@
>  def configure_hvm(config_image, vals):
>      """Create the config for HVM devices.
>      """
> -    args = [ 'device_model', 'pae', 'vcpus', 'boot', 'fda', 'fdb', 'timer_mode',
> +    args = [ 'device_model', 'pae', 'extid', 'vcpus', 'boot', 'fda', 'fdb', 'timer_mode',
>               'localtime', 'serial', 'stdvga', 'isa', 'nographic', 'soundhw',
>               'vnc', 'vncdisplay', 'vncunused', 'vncconsole', 'vnclisten',
>               'sdl', 'display', 'xauthority', 'rtc_timeoffset', 'monitor',


I'd still like to see the userspace tools side changed to not expose
the integrate 'extid' value to administrators configuring guests, and
instead use some semanatically meaningful string param

http://lists.xensource.com/archives/html/xen-devel/2008-03/msg00165.html

Regards,
Daniel.
-- 
|: Red Hat, Engineering, Boston   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|