Re: [PATCH][RFC] Supporting Enlightened Windows 2008Server

[Keir Fraser <keir.fraser@eu.citrix.com>]

On 5/4/08 00:24, "Ky Srinivasan" <ksrinivasan@novell.com> wrote:

> Based on the feedback I got from you and Tim, I am enclosing the next version
> of the patches to support enlightened win2008 server. Here are the changes I
> have made:
> 
> 1) I have put the shim on a low calorie diet - I have gotten rid of the
> framework infrastructure and to the extent possible integrated the shim code
> with xen.
> 
> 2) I have tried to cleanup the code. I am sure  more work will be needed here.
> 
> 3) I am not advertising the TLB related enlightenments. We can revisit this
> later if needed.

It's certainly quite a bit shorter which is good. For the remaining stuff,
do you have empirical evidence that performance is improved by it?

Other more minor comments are that the coding style is still off (e.g.,
start braces should go on their own line, spaces inside () for if/for/while
headers), you have at least one big switch statement where most of the cases
could be collapsed to just one shared block of code, and indeed shouldn't
the 'default' case in the hypercall demuxing switch statement be to return
'denied', and that would get rid of most of the individual cases altogether?

 -- Keir