From: Andrew Morton <akpm@linux-foundation.org>
To: eric miao <eric.y.miao@gmail.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-fbdev-devel@lists.sourceforge.net,
linux-arm-kernel email list
<linux-arm-kernel@lists.arm.linux.org.uk>,
Daniel Mack <daniel@caiaq.de>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] pxafb: preliminary smart panel interface support
Date: Tue, 8 Apr 2008 01:23:59 -0700 [thread overview]
Message-ID: <20080408012359.d0a7d0c8.akpm@linux-foundation.org> (raw)
In-Reply-To: <f17812d70804072107k77c2642ah23c8f2ce9535159f@mail.gmail.com>
On Tue, 8 Apr 2008 12:07:27 +0800 "eric miao" <eric.y.miao@gmail.com> wrote:
> +static int pxafb_smart_thread(void *arg)
> +{
> + struct pxafb_info *fbi = (struct pxafb_info *) arg;
Please don't typecast when assigning a pointer to or from void*.
Reasons:
- It defeats typechecking: if someone later converts `arg' to a u8, they
won't even get a compiler warning.
- Improved code readability.
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Register now and save $200. Hurry, offer ends at 11:59 p.m.,
Monday, April 7! Use priority code J8TLD2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: "eric miao" <eric.y.miao@gmail.com>
Cc: "linux-arm-kernel email list"
<linux-arm-kernel@lists.arm.linux.org.uk>,
linux-fbdev-devel@lists.sourceforge.net,
lkml <linux-kernel@vger.kernel.org>,
"Russell King - ARM Linux" <linux@arm.linux.org.uk>,
"Daniel Mack" <daniel@caiaq.de>
Subject: Re: [PATCH 4/4] pxafb: preliminary smart panel interface support
Date: Tue, 8 Apr 2008 01:23:59 -0700 [thread overview]
Message-ID: <20080408012359.d0a7d0c8.akpm@linux-foundation.org> (raw)
In-Reply-To: <f17812d70804072107k77c2642ah23c8f2ce9535159f@mail.gmail.com>
On Tue, 8 Apr 2008 12:07:27 +0800 "eric miao" <eric.y.miao@gmail.com> wrote:
> +static int pxafb_smart_thread(void *arg)
> +{
> + struct pxafb_info *fbi = (struct pxafb_info *) arg;
Please don't typecast when assigning a pointer to or from void*.
Reasons:
- It defeats typechecking: if someone later converts `arg' to a u8, they
won't even get a compiler warning.
- Improved code readability.
next prev parent reply other threads:[~2008-04-08 8:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-08 4:07 [PATCH 4/4] pxafb: preliminary smart panel interface support eric miao
2008-04-08 4:07 ` eric miao
2008-04-08 8:23 ` Andrew Morton [this message]
2008-04-08 8:23 ` Andrew Morton
2008-04-08 8:34 ` eric miao
2008-04-08 8:34 ` eric miao
2008-04-08 9:16 ` Russell King - ARM Linux
2008-04-08 9:47 ` eric miao
2008-04-08 9:47 ` eric miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080408012359.d0a7d0c8.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=daniel@caiaq.de \
--cc=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.