From: Paul Jackson <pj@sgi.com>
To: Mike Travis <travis@sgi.com>
Cc: bert.wesarg@googlemail.com, mingo@elte.hu, tglx@linutronix.de,
hpa@zytor.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] x86: modify show_shared_cpu_map in intel_cacheinfo v3
Date: Thu, 10 Apr 2008 09:03:31 -0500 [thread overview]
Message-ID: <20080410090331.da1900c5.pj@sgi.com> (raw)
In-Reply-To: <47FBD915.7020809@sgi.com>
Mike, in response to a suggestion from Bert, wrote:
> I have to subvert the cpumask interface a bit, but the resultant
> code size is about 7 instructions smaller.
I should have read ahead to this discussion, before responding
a minute ago with my suggestion using:
typedef enum { print_as_mask, print_as_list } map_printer_t;
I slightly dislike the subversion of the cpumask interface,
and slightly -do- like the 7 instructions saved.
Either of these variants (my typedef or Berts function pointer)
would be fine by me, as you prefer, Mike.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.940.382.4214
next prev parent reply other threads:[~2008-04-10 14:03 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-08 18:43 [PATCH 0/3] x86: add cpus_scnprintf function v3 Mike Travis
2008-04-08 18:43 ` [PATCH 1/3] x86: modify show_shared_cpu_map in intel_cacheinfo v3 Mike Travis
2008-04-08 19:36 ` Bert Wesarg
2008-04-08 20:44 ` Mike Travis
2008-04-10 14:03 ` Paul Jackson [this message]
2008-04-10 17:24 ` Bert Wesarg
2008-04-10 17:36 ` Paul Jackson
2008-04-10 13:57 ` Paul Jackson
2008-04-08 18:43 ` [PATCH 2/3] cpumask: use new cpus_scnprintf function v3 Mike Travis
2008-04-08 19:40 ` Bert Wesarg
2008-04-08 20:46 ` Mike Travis
2008-04-09 15:53 ` Bert Wesarg
2008-04-10 12:49 ` Paul Jackson
2008-04-10 0:32 ` Paul Jackson
2008-04-10 12:13 ` Paul Jackson
2008-04-10 14:05 ` Paul Jackson
2008-04-08 18:43 ` [PATCH 3/3] cpumask: add show cpu map functions v2 Mike Travis
2008-04-08 19:32 ` Bert Wesarg
2008-04-08 20:52 ` Mike Travis
2008-04-09 17:39 ` Bert Wesarg
2008-04-10 0:29 ` Paul Jackson
2008-04-10 6:05 ` Bert Wesarg
2008-04-10 14:13 ` Paul Jackson
2008-04-08 19:33 ` [PATCH 0/3] x86: add cpus_scnprintf function v3 Bert Wesarg
2008-04-08 20:54 ` Mike Travis
2008-04-10 15:03 ` Paul Jackson
2008-04-09 15:11 ` Ingo Molnar
2008-04-09 17:51 ` Bert Wesarg
2008-04-09 20:39 ` Greg KH
2008-04-09 20:52 ` Bert Wesarg
2008-04-09 21:14 ` Greg KH
2008-04-09 21:21 ` Bert Wesarg
2008-04-09 20:59 ` Mike Travis
2008-04-09 21:02 ` Bert Wesarg
2008-04-09 21:15 ` Greg KH
2008-04-10 0:18 ` Paul Jackson
2008-04-10 12:10 ` Paul Jackson
2008-04-10 16:14 ` Bert Wesarg
2008-04-10 16:27 ` Paul Jackson
2008-04-10 17:30 ` Greg KH
2008-04-10 17:36 ` Bert Wesarg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080410090331.da1900c5.pj@sgi.com \
--to=pj@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=bert.wesarg@googlemail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.