[lm-sensors] [Patch] lm-sensors crash on non x86 hardware

[lm-sensors] [Patch] lm-sensors crash on non x86 hardware

[Christian Krafft]

[-- Attachment #1.1: Type: text/plain, Size: 1491 bytes --]

Hi,

Please consider this tiny patch for inclusion.
It provides the user with more precise info.

Index: lm_sensors-2.10.0/prog/detect/sensors-detect
===================================================================
--- lm_sensors-2.10.0.orig/prog/detect/sensors-detect
+++ lm_sensors-2.10.0/prog/detect/sensors-detect
@@ -5153,7 +5153,7 @@ sub main
 
   print "\nSome chips are also accessible through the ISA bus. ISA probes are\n".
         "typically a bit more dangerous, as we have to write to I/O ports to do\n".
-        "this. This is usually safe though.\n\n";
+        "this. This is usually safe on x86 acrhitecture.\n\n";
   if ($> != 0) {
     print "As you are not root, we shall skip this step.\n";
   } else {
@@ -5167,7 +5167,7 @@ sub main
 
   print "\nSome Super I/O chips may also contain sensors. Super I/O probes are\n".
         "typically a bit more dangerous, as we have to write to I/O ports to do\n".
-        "this. This is usually safe though.\n\n";
+        "this. This is usually safe on x86 acrhitecture.\n\n";
   if ($> != 0) {
     print "As you are not root, we shall skip this step.\n";
   } else {


-- 
Mit freundlichen Gruessen,
kind regards,

Christian Krafft
IBM Systems & Technology Group,
Linux Kernel Development
IT Specialist


Vorsitzender des Aufsichtsrats:	Martin Jetter
Geschaeftsfuehrung:		Herbert Kircher
Sitz der Gesellschaft:		Boeblingen
Registriergericht:		Amtsgericht Stuttgart, HRB 243294

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [Patch] lm-sensors crash on non x86 hardware

[Jean Delvare]

Hi Christian,

On Thu, 10 Apr 2008 17:11:11 +0200, Christian Krafft wrote:
> Hi,
> 
> Please consider this tiny patch for inclusion.
> It provides the user with more precise info.
> 
> Index: lm_sensors-2.10.0/prog/detect/sensors-detect
> =================================> --- lm_sensors-2.10.0.orig/prog/detect/sensors-detect
> +++ lm_sensors-2.10.0/prog/detect/sensors-detect

2.10.0 is old...

> @@ -5153,7 +5153,7 @@ sub main
>  
>    print "\nSome chips are also accessible through the ISA bus. ISA probes are\n".
>          "typically a bit more dangerous, as we have to write to I/O ports to do\n".
> -        "this. This is usually safe though.\n\n";
> +        "this. This is usually safe on x86 acrhitecture.\n\n";
>    if ($> != 0) {
>      print "As you are not root, we shall skip this step.\n";
>    } else {
> @@ -5167,7 +5167,7 @@ sub main
>  
>    print "\nSome Super I/O chips may also contain sensors. Super I/O probes are\n".
>          "typically a bit more dangerous, as we have to write to I/O ports to do\n".
> -        "this. This is usually safe though.\n\n";
> +        "this. This is usually safe on x86 acrhitecture.\n\n";
>    if ($> != 0) {
>      print "As you are not root, we shall skip this step.\n";
>    } else {

We already skip these probes on PPC:
http://www.lm-sensors.org/changeset/5125
Isn't it sufficient?

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [Patch] lm-sensors crash on non x86 hardware

[Christian Krafft]

[-- Attachment #1.1: Type: text/plain, Size: 2007 bytes --]

Hi Jean,

On Thu, 10 Apr 2008 18:14:46 +0200
Jean Delvare <khali@linux-fr.org> wrote:

> Hi Christian,
> 
> On Thu, 10 Apr 2008 17:11:11 +0200, Christian Krafft wrote:
> > Hi,
> > 
> > Please consider this tiny patch for inclusion.
> > It provides the user with more precise info.
> > 
> > Index: lm_sensors-2.10.0/prog/detect/sensors-detect
> > ===================================================================
> > --- lm_sensors-2.10.0.orig/prog/detect/sensors-detect
> > +++ lm_sensors-2.10.0/prog/detect/sensors-detect
> 
> 2.10.0 is old...

Ups, Next time I'll check before posting ;-)

> 
> > @@ -5153,7 +5153,7 @@ sub main
> >  
> >    print "\nSome chips are also accessible through the ISA bus. ISA probes
> > are\n". "typically a bit more dangerous, as we have to write to I/O ports
> > to do\n".
> > -        "this. This is usually safe though.\n\n";
> > +        "this. This is usually safe on x86 acrhitecture.\n\n";
> >    if ($> != 0) {
> >      print "As you are not root, we shall skip this step.\n";
> >    } else {
> > @@ -5167,7 +5167,7 @@ sub main
> >  
> >    print "\nSome Super I/O chips may also contain sensors. Super I/O probes
> > are\n". "typically a bit more dangerous, as we have to write to I/O ports
> > to do\n".
> > -        "this. This is usually safe though.\n\n";
> > +        "this. This is usually safe on x86 acrhitecture.\n\n";
> >    if ($> != 0) {
> >      print "As you are not root, we shall skip this step.\n";
> >    } else {
> 
> We already skip these probes on PPC:
> http://www.lm-sensors.org/changeset/5125
> Isn't it sufficient?
> 

Thats perfect, more than I expected. Thanks!

-- 
Mit freundlichen Gruessen,
kind regards,

Christian Krafft
IBM Systems & Technology Group,
Linux Kernel Development
IT Specialist


Vorsitzender des Aufsichtsrats:	Martin Jetter
Geschaeftsfuehrung:		Herbert Kircher
Sitz der Gesellschaft:		Boeblingen
Registriergericht:		Amtsgericht Stuttgart, HRB 243294

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors