All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Roland McGrath <roland@redhat.com>,
	"Linus Torvalds <torvalds@linux-foundation.org>Andrew Morton"
	<akpm@linux-foundation.org>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	linux-s390@vger.kernel.org, tony.luck@intel.com,
	linux-ia64@vger.kernel.org, linux-arch@vger.kernel.org,
	linux-kernel@vger.kernel.org, miles@gnu.org,
	geert@linux-m68k.org, zippel@linux-m68k.org
Subject: Re: [PATCH 1/2] HAVE_SET_RESTORE_SIGMASK
Date: Thu, 10 Apr 2008 21:32:50 +0100	[thread overview]
Message-ID: <20080410203250.GA21589@flint.arm.linux.org.uk> (raw)
In-Reply-To: <1207741532.27048.64.camel@shinybook.infradead.org>

On Wed, Apr 09, 2008 at 12:45:32PM +0100, David Woodhouse wrote:
> On Fri, 2008-03-28 at 20:11 -0700, Roland McGrath wrote:
> > Change all the #ifdef TIF_RESTORE_SIGMASK conditionals in non-arch
> > code to #ifdef HAVE_SET_RESTORE_SIGMASK.
> 
> That ifdef was only supposed to be a temporary thing until all
> architectures had implemented TIF_RESTORE_SIGMASK anyway.
> 
> It looks like only ARM, v850 and m68k which are still missing it; if
> those three architectures can catch up, then hopefully it can die off
> completely quite soon.

Well, we don't have the pselect/ppoll/epoll_wait syscalls and there's
been no demand for them, so I don't particularly see the point of
going to the trouble of adding support for something no one's
interested in using.

I was going to suggest defining TIF_RESTORE_SIGMASK to zero to eliminate
some of the code (and the ifdefs), but unfortunately its a bit position
not a bitmask so that won't work.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:

WARNING: multiple messages have this Message-ID (diff)
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Roland McGrath <roland@redhat.com>,
	"Linus Torvalds <torvalds@linux-foundation.org>Andrew Morton"
	<akpm@linux-foundation.org>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	linux-s390@vger.kernel.org, tony.luck@intel.com,
	linux-ia64@vger.kernel.org, linux-arch@vger.kernel.org,
	linux-kernel@vger.kernel.org, miles@gnu.org,
	geert@linux-m68k.org, zippel@linux-m68k.org
Subject: Re: [PATCH 1/2] HAVE_SET_RESTORE_SIGMASK
Date: Thu, 10 Apr 2008 20:32:50 +0000	[thread overview]
Message-ID: <20080410203250.GA21589@flint.arm.linux.org.uk> (raw)
In-Reply-To: <1207741532.27048.64.camel@shinybook.infradead.org>

On Wed, Apr 09, 2008 at 12:45:32PM +0100, David Woodhouse wrote:
> On Fri, 2008-03-28 at 20:11 -0700, Roland McGrath wrote:
> > Change all the #ifdef TIF_RESTORE_SIGMASK conditionals in non-arch
> > code to #ifdef HAVE_SET_RESTORE_SIGMASK.
> 
> That ifdef was only supposed to be a temporary thing until all
> architectures had implemented TIF_RESTORE_SIGMASK anyway.
> 
> It looks like only ARM, v850 and m68k which are still missing it; if
> those three architectures can catch up, then hopefully it can die off
> completely quite soon.

Well, we don't have the pselect/ppoll/epoll_wait syscalls and there's
been no demand for them, so I don't particularly see the point of
going to the trouble of adding support for something no one's
interested in using.

I was going to suggest defining TIF_RESTORE_SIGMASK to zero to eliminate
some of the code (and the ifdefs), but unfortunately its a bit position
not a bitmask so that won't work.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:

  reply	other threads:[~2008-04-10 20:32 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-29  0:12 [PATCH 1/4] set_restore_sigmask Roland McGrath
2008-03-29  0:12 ` Roland McGrath
2008-03-29  0:12 ` Roland McGrath
     [not found] ` <20080329001230.D013726FA1D-nL1rrgvulkcB9AHHLWeGtNQXobZC6xk2@public.gmane.org>
2008-03-29  0:13   ` [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING Roland McGrath
2008-03-29  0:13     ` Roland McGrath
2008-03-29  0:13     ` Roland McGrath
2008-03-29  0:13     ` Roland McGrath
     [not found]     ` <20080329001341.7F93826FA1D-nL1rrgvulkcB9AHHLWeGtNQXobZC6xk2@public.gmane.org>
2008-03-29  0:53       ` Linus Torvalds
2008-03-29  0:53         ` Linus Torvalds
2008-03-29  0:53         ` Linus Torvalds
     [not found]         ` <alpine.LFD.1.00.0803281746480.14670-5CScLwifNT1QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
2008-03-29  2:24           ` Roland McGrath
2008-03-29  2:24             ` Roland McGrath
2008-03-29  2:24             ` Roland McGrath
2008-03-29  2:52             ` Linus Torvalds
2008-03-29  2:52               ` Linus Torvalds
     [not found]               ` <alpine.LFD.1.00.0803281942440.14670-5CScLwifNT1QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
2008-03-29  3:12                 ` Roland McGrath
2008-03-29  3:12                   ` Roland McGrath
2008-03-29  3:12                   ` Roland McGrath
     [not found]             ` <20080329022408.0DD4726FA1D-nL1rrgvulkcB9AHHLWeGtNQXobZC6xk2@public.gmane.org>
2008-03-29  3:11               ` [PATCH 1/2] HAVE_SET_RESTORE_SIGMASK Roland McGrath
2008-03-29  3:11                 ` Roland McGrath
2008-03-29  3:11                 ` Roland McGrath
2008-04-09 11:45                 ` David Woodhouse
2008-04-09 11:45                   ` David Woodhouse
2008-04-10 20:32                   ` Russell King [this message]
2008-04-10 20:32                     ` Russell King
     [not found]                     ` <20080410203250.GA21589-f404yB8NqCZvn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2008-04-11 13:40                       ` David Woodhouse
2008-04-11 13:40                         ` David Woodhouse
2008-04-11 13:40                         ` David Woodhouse
2008-03-29  3:14             ` Roland McGrath
2008-03-29  3:14               ` Roland McGrath
2008-03-29  3:14               ` [PATCH 2/2] x86 TS_RESTORE_SIGMASK Roland McGrath
2008-03-29  3:14                 ` Roland McGrath
2008-03-31 13:01                 ` Ingo Molnar
2008-03-31 13:01                   ` Ingo Molnar
2008-03-31 19:30                   ` Roland McGrath
2008-03-31 19:30                     ` Roland McGrath
2008-03-30 10:53           ` [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING Paul Mackerras
2008-03-30 10:53             ` Paul Mackerras
2008-03-30 10:53             ` Paul Mackerras
2008-04-08 11:35           ` Oleg Nesterov
2008-04-08 11:35             ` Oleg Nesterov
2008-04-08 11:35             ` Oleg Nesterov
     [not found]             ` <20080408113519.GA227-6lXkIZvqkOAvJsYlp49lxw@public.gmane.org>
2008-04-08 14:53               ` Linus Torvalds
2008-04-08 14:53                 ` Linus Torvalds
2008-04-08 14:53                 ` Linus Torvalds
2008-04-08 19:51               ` Roland McGrath
2008-04-08 19:51                 ` Roland McGrath
2008-04-08 19:51                 ` Roland McGrath
2008-04-09 11:16             ` David Woodhouse
2008-04-09 11:16               ` David Woodhouse
     [not found]               ` <1207739787.27048.57.camel-Fexsq3y4057IgHVZqg5X0TlWvGAXklZc@public.gmane.org>
2008-04-09 11:39                 ` Oleg Nesterov
2008-04-09 11:39                   ` Oleg Nesterov
2008-04-09 11:39                   ` Oleg Nesterov
2008-04-09 12:57                   ` Petr Tesarik
2008-04-09 12:57                     ` Petr Tesarik
     [not found]                   ` <20080409113939.GA99-6lXkIZvqkOAvJsYlp49lxw@public.gmane.org>
2008-04-09 16:14                     ` David Woodhouse
2008-04-09 16:14                       ` David Woodhouse
2008-04-09 16:14                       ` David Woodhouse
2008-04-09 16:22                       ` Oleg Nesterov
2008-04-09 16:22                         ` Oleg Nesterov
2008-04-09 18:40                         ` David Woodhouse
2008-04-09 18:40                           ` David Woodhouse
2008-03-29  0:14   ` [PATCH 3/4] s390 renumber TIF_RESTORE_SIGMASK Roland McGrath
2008-03-29  0:14     ` Roland McGrath
2008-03-29  0:14     ` Roland McGrath
2008-03-29  0:14     ` Roland McGrath
2008-03-31  7:53     ` Martin Schwidefsky
2008-03-31  7:53       ` Martin Schwidefsky
2008-03-29  0:14 ` [PATCH 4/4] ia64 " Roland McGrath
2008-03-29  0:14   ` Roland McGrath
2008-03-29  0:14   ` Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080410203250.GA21589@flint.arm.linux.org.uk \
    --to=rmk+lkml@arm.linux.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=dwmw2@infradead.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=miles@gnu.org \
    --cc=roland@redhat.com \
    --cc=schwidefsky@de.ibm.com \
    --cc=tony.luck@intel.com \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.