* iwlwifi integer overflow warnings
@ 2008-04-10 8:26 Meelis Roos
2008-04-10 20:29 ` Chatre, Reinette
0 siblings, 1 reply; 5+ messages in thread
From: Meelis Roos @ 2008-04-10 8:26 UTC (permalink / raw)
To: linux-wireless, yi.zhu, reinette.chatre
(In case anyone is interested)
This is todays 2.6.25-rc8+git on ppc (not powerpc) arch (32-bit),
gcc version 4.3.1 20080401 (prerelease) (Debian 4.3.0-3)
drivers/net/wireless/iwlwifi/iwl3945-base.c: In function 'iwl3945_enqueue_hcmd':
drivers/net/wireless/iwlwifi/iwl3945-base.c:719: warning: integer overflow in expression
drivers/net/wireless/iwlwifi/iwl-3945.c: In function 'iwl3945_add_radiotap':
drivers/net/wireless/iwlwifi/iwl-3945.c:326: warning: integer overflow in expression
drivers/net/wireless/iwlwifi/iwl4965-base.c: In function 'iwl4965_enqueue_hcmd':
drivers/net/wireless/iwlwifi/iwl4965-base.c:723: warning: integer overflow in expression
drivers/net/wireless/iwlwifi/iwl-4965.c: In function 'iwl4965_add_radiotap':
drivers/net/wireless/iwlwifi/iwl-4965.c:3617: warning: integer overflow in expression
--
Meelis Roos (mroos@linux.ee)
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: iwlwifi integer overflow warnings
2008-04-10 8:26 iwlwifi integer overflow warnings Meelis Roos
@ 2008-04-10 20:29 ` Chatre, Reinette
2008-04-11 12:16 ` Johannes Berg
0 siblings, 1 reply; 5+ messages in thread
From: Chatre, Reinette @ 2008-04-10 20:29 UTC (permalink / raw)
To: Meelis Roos, linux-wireless, Zhu, Yi, Johannes Berg,
John W. Linville
On , Meelis Roos wrote:
> (In case anyone is interested)
>
> This is todays 2.6.25-rc8+git on ppc (not powerpc) arch (32-bit),
> gcc version 4.3.1 20080401 (prerelease) (Debian 4.3.0-3)
>
> drivers/net/wireless/iwlwifi/iwl3945-base.c: In function
> 'iwl3945_enqueue_hcmd':
> drivers/net/wireless/iwlwifi/iwl3945-base.c:719: warning: integer
> overflow in expression drivers/net/wireless/iwlwifi/iwl-3945.c: In
> function 'iwl3945_add_radiotap':
> drivers/net/wireless/iwlwifi/iwl-3945.c:326: warning: integer
> overflow in expression drivers/net/wireless/iwlwifi/iwl4965-base.c:
> In function 'iwl4965_enqueue_hcmd':
> drivers/net/wireless/iwlwifi/iwl4965-base.c:723: warning: integer
> overflow in expression drivers/net/wireless/iwlwifi/iwl-4965.c: In
> function 'iwl4965_add_radiotap':
> drivers/net/wireless/iwlwifi/iwl-4965.c:3617: warning: integer
> overflow in expression
>
(adding Johannes and John)
These problems have been fixed by Johannes with his patch "iwlwifi:fix
some warnings". If this is an issue in 2.6.25 then that kernel may take
this patch to address the problem.
Reinette
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: iwlwifi integer overflow warnings
2008-04-10 20:29 ` Chatre, Reinette
@ 2008-04-11 12:16 ` Johannes Berg
2008-04-11 12:27 ` John W. Linville
2008-04-11 14:55 ` Chatre, Reinette
0 siblings, 2 replies; 5+ messages in thread
From: Johannes Berg @ 2008-04-11 12:16 UTC (permalink / raw)
To: Chatre, Reinette; +Cc: Meelis Roos, linux-wireless, Zhu, Yi, John W. Linville
[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]
> > drivers/net/wireless/iwlwifi/iwl3945-base.c: In function
> > 'iwl3945_enqueue_hcmd':
> > drivers/net/wireless/iwlwifi/iwl3945-base.c:719: warning: integer
> > overflow in expression drivers/net/wireless/iwlwifi/iwl-3945.c: In
> > function 'iwl3945_add_radiotap':
> > drivers/net/wireless/iwlwifi/iwl-3945.c:326: warning: integer
> > overflow in expression drivers/net/wireless/iwlwifi/iwl4965-base.c:
> > In function 'iwl4965_enqueue_hcmd':
> > drivers/net/wireless/iwlwifi/iwl4965-base.c:723: warning: integer
> > overflow in expression drivers/net/wireless/iwlwifi/iwl-4965.c: In
> > function 'iwl4965_add_radiotap':
> > drivers/net/wireless/iwlwifi/iwl-4965.c:3617: warning: integer
> > overflow in expression
> >
>
> (adding Johannes and John)
>
> These problems have been fixed by Johannes with his patch "iwlwifi:fix
> some warnings". If this is an issue in 2.6.25 then that kernel may take
> this patch to address the problem.
That patch never was applied though and Tomas had reservations. I didn't
have time to look at it again.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: iwlwifi integer overflow warnings
2008-04-11 12:16 ` Johannes Berg
@ 2008-04-11 12:27 ` John W. Linville
2008-04-11 14:55 ` Chatre, Reinette
1 sibling, 0 replies; 5+ messages in thread
From: John W. Linville @ 2008-04-11 12:27 UTC (permalink / raw)
To: Johannes Berg; +Cc: Chatre, Reinette, Meelis Roos, linux-wireless, Zhu, Yi
On Fri, Apr 11, 2008 at 02:16:44PM +0200, Johannes Berg wrote:
>
> > > drivers/net/wireless/iwlwifi/iwl3945-base.c: In function
> > > 'iwl3945_enqueue_hcmd':
> > > drivers/net/wireless/iwlwifi/iwl3945-base.c:719: warning: integer
> > > overflow in expression drivers/net/wireless/iwlwifi/iwl-3945.c: In
> > > function 'iwl3945_add_radiotap':
> > > drivers/net/wireless/iwlwifi/iwl-3945.c:326: warning: integer
> > > overflow in expression drivers/net/wireless/iwlwifi/iwl4965-base.c:
> > > In function 'iwl4965_enqueue_hcmd':
> > > drivers/net/wireless/iwlwifi/iwl4965-base.c:723: warning: integer
> > > overflow in expression drivers/net/wireless/iwlwifi/iwl-4965.c: In
> > > function 'iwl4965_add_radiotap':
> > > drivers/net/wireless/iwlwifi/iwl-4965.c:3617: warning: integer
> > > overflow in expression
> > >
> >
> > (adding Johannes and John)
> >
> > These problems have been fixed by Johannes with his patch "iwlwifi:fix
> > some warnings". If this is an issue in 2.6.25 then that kernel may take
> > this patch to address the problem.
>
> That patch never was applied though and Tomas had reservations. I didn't
> have time to look at it again.
Actually, I factored-out the parts Tomas didn't like and applied it.
--
John W. Linville
linville@tuxdriver.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: iwlwifi integer overflow warnings
2008-04-11 12:16 ` Johannes Berg
2008-04-11 12:27 ` John W. Linville
@ 2008-04-11 14:55 ` Chatre, Reinette
1 sibling, 0 replies; 5+ messages in thread
From: Chatre, Reinette @ 2008-04-11 14:55 UTC (permalink / raw)
To: Johannes Berg; +Cc: Meelis Roos, linux-wireless, Zhu, Yi, John W. Linville
On Friday, April 11, 2008 5:17 AM, Johannes Berg wrote:
>>> drivers/net/wireless/iwlwifi/iwl3945-base.c: In function
>>> 'iwl3945_enqueue_hcmd':
>>> drivers/net/wireless/iwlwifi/iwl3945-base.c:719: warning: integer
>>> overflow in expression drivers/net/wireless/iwlwifi/iwl-3945.c: In
>>> function 'iwl3945_add_radiotap':
>>> drivers/net/wireless/iwlwifi/iwl-3945.c:326: warning: integer
>>> overflow in expression drivers/net/wireless/iwlwifi/iwl4965-base.c:
>>> In function 'iwl4965_enqueue_hcmd':
>>> drivers/net/wireless/iwlwifi/iwl4965-base.c:723: warning: integer
>>> overflow in expression drivers/net/wireless/iwlwifi/iwl-4965.c: In
>>> function 'iwl4965_add_radiotap':
>>> drivers/net/wireless/iwlwifi/iwl-4965.c:3617: warning: integer
>>> overflow in expression
>>>
>>
>> (adding Johannes and John)
>>
>> These problems have been fixed by Johannes with his patch
>> "iwlwifi:fix some warnings". If this is an issue in 2.6.25 then that
>> kernel may take this patch to address the problem.
>
> That patch never was applied though and Tomas had
> reservations. I didn't
> have time to look at it again.
I did find it in the current wireless-testing as commit
cb08e71a7bc92a5ad518758584f077ed81d62b5c
Reinette
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-04-11 14:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-10 8:26 iwlwifi integer overflow warnings Meelis Roos
2008-04-10 20:29 ` Chatre, Reinette
2008-04-11 12:16 ` Johannes Berg
2008-04-11 12:27 ` John W. Linville
2008-04-11 14:55 ` Chatre, Reinette
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.