All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86_64: don't need set default res if only have one root bus
@ 2008-04-11 22:14 Yinghai Lu
  2008-04-11 22:54 ` Rafael J. Wysocki
  0 siblings, 1 reply; 3+ messages in thread
From: Yinghai Lu @ 2008-04-11 22:14 UTC (permalink / raw)
  To: Rafael J. Wysocki, Ingo Molnar; +Cc: kernel list

only one root bus, don't need to split that root resources.

Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>

diff --git a/arch/x86/pci/k8-bus_64.c b/arch/x86/pci/k8-bus_64.c
index 7ed7f51..c433982 100644
--- a/arch/x86/pci/k8-bus_64.c
+++ b/arch/x86/pci/k8-bus_64.c
@@ -69,7 +69,8 @@ void set_pci_bus_resources_arch_default(struct pci_bus *b)
 	int j;
 	struct pci_root_info *info;
 
-	if (!pci_root_num)
+	/* if only one root bus, don't need to anything */
+	if (pci_root_num < 2)
 		return;
 
 	for (i = 0; i < pci_root_num; i++) {

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] x86_64: don't need set default res if only have one root bus
  2008-04-11 22:14 [PATCH] x86_64: don't need set default res if only have one root bus Yinghai Lu
@ 2008-04-11 22:54 ` Rafael J. Wysocki
  2008-04-13  7:47   ` Ingo Molnar
  0 siblings, 1 reply; 3+ messages in thread
From: Rafael J. Wysocki @ 2008-04-11 22:54 UTC (permalink / raw)
  To: yhlu.kernel; +Cc: Ingo Molnar, kernel list, Andrew Morton

On Saturday, 12 of April 2008, Yinghai Lu wrote:
> only one root bus, don't need to split that root resources.

This patch fixes the issue described at
http://lkml.org/lkml/2008/4/10/304 and in the following thread for me.

> Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>

Tested-by: Rafael J. Wysocki <rjw@sisk.pl>
 
> diff --git a/arch/x86/pci/k8-bus_64.c b/arch/x86/pci/k8-bus_64.c
> index 7ed7f51..c433982 100644
> --- a/arch/x86/pci/k8-bus_64.c
> +++ b/arch/x86/pci/k8-bus_64.c
> @@ -69,7 +69,8 @@ void set_pci_bus_resources_arch_default(struct pci_bus *b)
>  	int j;
>  	struct pci_root_info *info;
>  
> -	if (!pci_root_num)
> +	/* if only one root bus, don't need to anything */
> +	if (pci_root_num < 2)
>  		return;
>  
>  	for (i = 0; i < pci_root_num; i++) {
> 
> 

Thanks,
Rafael

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] x86_64: don't need set default res if only have one root bus
  2008-04-11 22:54 ` Rafael J. Wysocki
@ 2008-04-13  7:47   ` Ingo Molnar
  0 siblings, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2008-04-13  7:47 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: yhlu.kernel, kernel list, Andrew Morton


* Rafael J. Wysocki <rjw@sisk.pl> wrote:

> On Saturday, 12 of April 2008, Yinghai Lu wrote:
> > only one root bus, don't need to split that root resources.
> 
> This patch fixes the issue described at
> http://lkml.org/lkml/2008/4/10/304 and in the following thread for me.
> 
> > Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
> 
> Tested-by: Rafael J. Wysocki <rjw@sisk.pl>

thanks - applied.

	Ingo

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-04-13  7:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-11 22:14 [PATCH] x86_64: don't need set default res if only have one root bus Yinghai Lu
2008-04-11 22:54 ` Rafael J. Wysocki
2008-04-13  7:47   ` Ingo Molnar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.