From: Scott Wood <scottwood@freescale.com>
To: Andy Fleming <afleming@freescale.com>
Cc: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org,
paul.gortmaker@windriver.com
Subject: Re: [PATCH v2.6.26] gianfar: Determine TBIPA value dynamically
Date: Fri, 11 Apr 2008 10:31:25 -0500 [thread overview]
Message-ID: <20080411153125.GA2588@loki.buserror.net> (raw)
In-Reply-To: <1207870471-3601-1-git-send-email-afleming@freescale.com>
On Thu, Apr 10, 2008 at 06:34:31PM -0500, Andy Fleming wrote:
>
> + /*
> + * This is mildly evil, but so is our hardware for doing this.
> + * Also, we have to cast back to struct gfar_mii because of
> + * definition weirdness done in gianfar.h.
> + */
> + enet_regs = (struct gfar __iomem *)
> + ((char *)regs - offsetof(struct gfar, gfar_mii_regs));
Can we use to_container() here?
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Andy Fleming <afleming@freescale.com>
Cc: netdev@vger.kernel.org, paul.gortmaker@windriver.com,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v2.6.26] gianfar: Determine TBIPA value dynamically
Date: Fri, 11 Apr 2008 10:31:25 -0500 [thread overview]
Message-ID: <20080411153125.GA2588@loki.buserror.net> (raw)
In-Reply-To: <1207870471-3601-1-git-send-email-afleming@freescale.com>
On Thu, Apr 10, 2008 at 06:34:31PM -0500, Andy Fleming wrote:
>
> + /*
> + * This is mildly evil, but so is our hardware for doing this.
> + * Also, we have to cast back to struct gfar_mii because of
> + * definition weirdness done in gianfar.h.
> + */
> + enet_regs = (struct gfar __iomem *)
> + ((char *)regs - offsetof(struct gfar, gfar_mii_regs));
Can we use to_container() here?
-Scott
next prev parent reply other threads:[~2008-04-11 15:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 23:34 [PATCH v2.6.26] gianfar: Determine TBIPA value dynamically Andy Fleming
2008-04-10 23:34 ` Andy Fleming
2008-04-11 15:31 ` Scott Wood [this message]
2008-04-11 15:31 ` Scott Wood
2008-04-11 19:06 ` Andy Fleming
2008-04-11 19:06 ` Andy Fleming
2008-04-11 19:11 ` Scott Wood
2008-04-11 19:11 ` Scott Wood
2008-04-11 15:49 ` Paul Gortmaker
2008-04-14 16:55 ` Andy Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080411153125.GA2588@loki.buserror.net \
--to=scottwood@freescale.com \
--cc=afleming@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.