Re: Infinite loop regression due to recent change in hostfs.c

[Robert Millan <rmh@aybabtu.com>]

On Sun, Apr 06, 2008 at 01:21:31PM -0400, Pavel Roskin wrote:
> Quoting Christian Franke <Christian.Franke@t-online.de>:
> 
> >The change in hostfs.c introduces an interesting regression: hostfs now
> >appears in *_init.lst and grub_hostfs_init() is called twice in
> >grub-emu and grub-fstest. This results in a infinite loop because the
> >hostfs entry of grub_fs_list points to itself.
> 
> Thanks for noticing the problem and for the analysis!
> 
> >You should either undo this change or remove extra calls to
> >grub_hostfs_init/fini from grub-emu.c and grub-fstest.c. The latter
> >might not work if it is necessary to init hostfs first for some reason.
> 
> I've removed the extra calls.  I don't see any reasons why hostfs  
> should be registered first.

I suspect it was a remnant from before we had grub_init_all().

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)