All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Cc: Michael Guntsche <mike@it-loops.com>
Subject: Re: [PATCH] Fix prefix problem with LVM on RAID
Date: Sun, 13 Apr 2008 17:04:26 +0200	[thread overview]
Message-ID: <20080413150426.GB25883@thorin> (raw)
In-Reply-To: <CA499705-8705-4B82-BE03-871258EE6442@it-loops.com>

[-- Attachment #1: Type: text/plain, Size: 921 bytes --]

On Sat, Feb 23, 2008 at 09:54:35PM +0100, Michael Guntsche wrote:
> Hello,
> 
> While testing a soon to be deployed setup here I noticed that grub- 
> setup is setting the prefix wrong if you run
> LVM on Software RAID
> 
> grub-setup -v /dev/md0
> ...
> grub-setup: info: dos partition is -2, bsd partition is -2, prefix is  
> (md0)(fatoftheland-main)/boot/grub
> ...
> 
> As you can see the there is also (md0) in the prefix which does not  
> work.
> Attached a small patch that fixes this problem for me. I am not sure  
> if it is the best way to fix it so please take a look.
> If the root device is on LVM only add the LVM part if it is on RAID  
> only add the RAID part.

Sorry for the delay in repliing.  I think it's more correct this way.  Does
it work for you?

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)

[-- Attachment #2: lvm_on_raid.diff --]
[-- Type: text/x-diff, Size: 474 bytes --]

diff -x configure -x config.h.in -x CVS -x '*~' -x '*.mk' -urp ../grub2/util/i386/pc/grub-setup.c ./util/i386/pc/grub-setup.c
--- ../grub2/util/i386/pc/grub-setup.c	2008-02-19 15:00:11.000000000 +0100
+++ ./util/i386/pc/grub-setup.c	2008-04-13 17:03:21.000000000 +0200
@@ -749,6 +749,7 @@ main (int argc, char *argv[])
       prefix = newprefix;
     }
     
+  else
   if (dest_dev[0] == 'm' && dest_dev[1] == 'd'
       && dest_dev[2] >= '0' && dest_dev[2] <= '9')
     {

  parent reply	other threads:[~2008-04-13 15:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-23 20:54 [PATCH] Fix prefix problem with LVM on RAID Michael Guntsche
2008-02-24 16:37 ` Michael Guntsche
2008-04-13 15:04 ` Robert Millan [this message]
2008-04-13 16:07   ` Guntsche Michael
2008-04-13 16:40     ` Robert Millan
2008-04-13 17:03       ` Guntsche Michael

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080413150426.GB25883@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    --cc=mike@it-loops.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.