All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarek Poplawski <jarkao2@gmail.com>
To: Patrick McHardy <kaber@trash.net>
Cc: David Miller <davem@davemloft.net>,
	pebolle@tiscali.nl, netdev@vger.kernel.org,
	isdn4linux@listserv.isdn4linux.de, jgarzik@redhat.com
Subject: Re: [PATCH] [NET] [ISDN]: Do not validate ISDN net device address prior to interface-up
Date: Mon, 14 Apr 2008 06:07:20 +0000	[thread overview]
Message-ID: <20080414060720.GB4016@ff.dom.local> (raw)
In-Reply-To: <4802F24B.7060104@trash.net>

On Mon, Apr 14, 2008 at 07:57:31AM +0200, Patrick McHardy wrote:
> Jarek Poplawski wrote:
...
>> Maybe I missed Patrick point, but it seems this patch isn't good:
>> it omits address validation hiding possible problems.
> The ISDN device's address is computed from the IP addresses
> in ->open(), so there is nothing to validate at the time
> eth_validate_addr() is called.

...So I missed the point, sorry!

Thanks for the explanation,
Jarek P.

  reply	other threads:[~2008-04-14  6:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-10 15:00 [PATCH] [NET] [ISDN]: Do not validate ISDN net device address prior to interface-up Paul Bolle
2008-04-13  6:29 ` Patrick McHardy
2008-04-13  8:06   ` Jarek Poplawski
2008-04-13  8:05     ` Patrick McHardy
2008-04-13  8:27       ` Jarek Poplawski
2008-04-13  8:26         ` Patrick McHardy
2008-04-13  8:51           ` Jarek Poplawski
2008-04-14  5:46   ` David Miller
2008-04-14  5:44 ` David Miller
2008-04-14  6:01   ` Jarek Poplawski
2008-04-14  5:57     ` Patrick McHardy
2008-04-14  6:07       ` Jarek Poplawski [this message]
2008-04-14  6:32       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080414060720.GB4016@ff.dom.local \
    --to=jarkao2@gmail.com \
    --cc=davem@davemloft.net \
    --cc=isdn4linux@listserv.isdn4linux.de \
    --cc=jgarzik@redhat.com \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.