From: Patrick McHardy <kaber@trash.net>
To: Jarek Poplawski <jarkao2@gmail.com>
Cc: Paul Bolle <pebolle@tiscali.nl>,
netdev@vger.kernel.org, isdn4linux@listserv.isdn4linux.de,
Jeff Garzik <jgarzik@redhat.com>
Subject: Re: [PATCH] [NET] [ISDN]: Do not validate ISDN net device address prior to interface-up
Date: Sun, 13 Apr 2008 10:05:08 +0200 [thread overview]
Message-ID: <4801BEB4.6090909@trash.net> (raw)
In-Reply-To: <4801BF1C.30207@gmail.com>
Jarek Poplawski wrote:
> Patrick McHardy wrote, On 04/13/2008 08:29 AM:
> ...
>
>
>> I guess it should return -EADDRNOTAVAIL similar to eth_mac_addr()
>> when validation fails.
>>
>
> I think an additional printk should really save some time in guessing
> what's wrong and with which address, especially if the same config
> works OK with earlier kernels.
>
In my opinion a proper error code like EADDRNOTAVAIL is enough, we
have thousands of checks that might make things fail, should we
add a printk to every one of those?
next prev parent reply other threads:[~2008-04-13 8:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 15:00 [PATCH] [NET] [ISDN]: Do not validate ISDN net device address prior to interface-up Paul Bolle
2008-04-13 6:29 ` Patrick McHardy
2008-04-13 8:06 ` Jarek Poplawski
2008-04-13 8:05 ` Patrick McHardy [this message]
2008-04-13 8:27 ` Jarek Poplawski
2008-04-13 8:26 ` Patrick McHardy
2008-04-13 8:51 ` Jarek Poplawski
2008-04-14 5:46 ` David Miller
2008-04-14 5:44 ` David Miller
2008-04-14 6:01 ` Jarek Poplawski
2008-04-14 5:57 ` Patrick McHardy
2008-04-14 6:07 ` Jarek Poplawski
2008-04-14 6:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4801BEB4.6090909@trash.net \
--to=kaber@trash.net \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=jarkao2@gmail.com \
--cc=jgarzik@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.