From: Jeff Dike <jdike@addtoit.com>
To: WANG Cong <xiyou.wangcong@gmail.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] [Patch] arch/um/os-Linux/sys-i386/task_size.c: improve a bit
Date: Mon, 14 Apr 2008 10:59:17 -0400 [thread overview]
Message-ID: <20080414145917.GC7186@c2.user-mode-linux.org> (raw)
In-Reply-To: <20080412.171747.26924099.xiyou.wangcong@gmail.com>
On Sat, Apr 12, 2008 at 05:17:47PM +0800, WANG Cong wrote:
> Improve this code a bit: check sigaction's return value and remove a useless
> fflush().
This looks fine. BTW, some of the fflushing is on purpose, although
the one you removed does indeed look useless. I want all output from
early boot to hit the screen as soon as possible, even in the absence
(so far) of a newline. So, if there's any doubt about whether a
printf has a newline in it, it's flushed.
Jeff
--
Work email - jdike at linux dot intel dot com
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Dike <jdike@addtoit.com>
To: WANG Cong <xiyou.wangcong@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [Patch] arch/um/os-Linux/sys-i386/task_size.c: improve a bit
Date: Mon, 14 Apr 2008 10:59:17 -0400 [thread overview]
Message-ID: <20080414145917.GC7186@c2.user-mode-linux.org> (raw)
In-Reply-To: <20080412.171747.26924099.xiyou.wangcong@gmail.com>
On Sat, Apr 12, 2008 at 05:17:47PM +0800, WANG Cong wrote:
> Improve this code a bit: check sigaction's return value and remove a useless
> fflush().
This looks fine. BTW, some of the fflushing is on purpose, although
the one you removed does indeed look useless. I want all output from
early boot to hit the screen as soon as possible, even in the absence
(so far) of a newline. So, if there's any doubt about whether a
printf has a newline in it, it's flushed.
Jeff
--
Work email - jdike at linux dot intel dot com
next prev parent reply other threads:[~2008-04-14 15:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-12 9:17 [uml-devel] [Patch] arch/um/os-Linux/sys-i386/task_size.c: improve a bit WANG Cong
2008-04-12 9:17 ` WANG Cong
2008-04-14 14:59 ` Jeff Dike [this message]
2008-04-14 14:59 ` Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080414145917.GC7186@c2.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.