From: Jeff Dike <jdike@addtoit.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Li Zefan <lizf@cn.fujitsu.com>,
balbir@linux.vnet.ibm.com,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Pavel Emelianov <xemul@openvz.org>,
Roland McGrath <roland@redhat.com>
Subject: Re: s/PF_BORROWED_MM/PF_KTHREAD/ (was: kernel warning: tried to kill an mm-less task!)
Date: Tue, 15 Apr 2008 13:10:48 -0400 [thread overview]
Message-ID: <20080415171048.GA11441@c2.user-mode-linux.org> (raw)
In-Reply-To: <20080415101905.GB89@tv-sign.ru>
On Tue, Apr 15, 2008 at 02:19:05PM +0400, Oleg Nesterov wrote:
> First, include/asm-um/mmu_context.h:activate_mm() doesn't look right to me,
> use_mm() does switch_mm(), not activate_mm(), so I think we can do
>
> --- include/asm-um/mmu_context.h 2008-02-17 23:40:08.000000000 +0300
> +++ - 2008-04-15 13:35:34.089295980 +0400
> @@ -29,7 +29,7 @@ static inline void activate_mm(struct mm
> * host. Since they're very expensive, we want to avoid that as far as
> * possible.
> */
> - if (old != new && (current->flags & PF_BORROWED_MM))
> + if (old != new)
> __switch_mm(&new->context.id);
>
> arch_dup_mmap(old, new);
I'm thinking I can just change this to call switch_mm, getting rid of
the old != new test too.
Plus, you can get rid of the comment in use_mm about UML needing
PF_BORROWED_MM.
I'll test this to make sure.
Jeff
--
Work email - jdike at linux dot intel dot com
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Dike <jdike@addtoit.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Li Zefan <lizf@cn.fujitsu.com>,
balbir@linux.vnet.ibm.com,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Pavel Emelianov <xemul@openvz.org>,
Roland McGrath <roland@redhat.com>
Subject: Re: s/PF_BORROWED_MM/PF_KTHREAD/ (was: kernel warning: tried to kill an mm-less task!)
Date: Tue, 15 Apr 2008 13:10:48 -0400 [thread overview]
Message-ID: <20080415171048.GA11441@c2.user-mode-linux.org> (raw)
In-Reply-To: <20080415101905.GB89@tv-sign.ru>
On Tue, Apr 15, 2008 at 02:19:05PM +0400, Oleg Nesterov wrote:
> First, include/asm-um/mmu_context.h:activate_mm() doesn't look right to me,
> use_mm() does switch_mm(), not activate_mm(), so I think we can do
>
> --- include/asm-um/mmu_context.h 2008-02-17 23:40:08.000000000 +0300
> +++ - 2008-04-15 13:35:34.089295980 +0400
> @@ -29,7 +29,7 @@ static inline void activate_mm(struct mm
> * host. Since they're very expensive, we want to avoid that as far as
> * possible.
> */
> - if (old != new && (current->flags & PF_BORROWED_MM))
> + if (old != new)
> __switch_mm(&new->context.id);
>
> arch_dup_mmap(old, new);
I'm thinking I can just change this to call switch_mm, getting rid of
the old != new test too.
Plus, you can get rid of the comment in use_mm about UML needing
PF_BORROWED_MM.
I'll test this to make sure.
Jeff
--
Work email - jdike at linux dot intel dot com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-04-15 17:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-14 7:09 kernel warning: tried to kill an mm-less task! Li Zefan
2008-04-14 7:09 ` Li Zefan
2008-04-14 7:46 ` KAMEZAWA Hiroyuki
2008-04-14 7:46 ` KAMEZAWA Hiroyuki
2008-04-14 8:01 ` Balbir Singh
2008-04-14 8:01 ` Balbir Singh
2008-04-14 8:06 ` Li Zefan
2008-04-14 8:06 ` Li Zefan
2008-04-15 3:47 ` Li Zefan
2008-04-15 3:47 ` Li Zefan
2008-04-15 6:17 ` Oleg Nesterov
2008-04-15 6:17 ` Oleg Nesterov
2008-04-15 10:19 ` s/PF_BORROWED_MM/PF_KTHREAD/ (was: kernel warning: tried to kill an mm-less task!) Oleg Nesterov
2008-04-15 10:19 ` Oleg Nesterov
2008-04-15 17:10 ` Jeff Dike [this message]
2008-04-15 17:10 ` Jeff Dike
2008-04-15 20:58 ` kernel warning: tried to kill an mm-less task! Roland McGrath
2008-04-15 20:58 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080415171048.GA11441@c2.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=oleg@tv-sign.ru \
--cc=roland@redhat.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.