From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Adrian Bunk <bunk@kernel.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pcmcia@lists.infradead.org,
Russell King <rmk@arm.linux.org.uk>
Subject: Re: [2.6 patch] PCMCIA mustn't select HAVE_IDE
Date: Tue, 15 Apr 2008 22:15:34 +0200 [thread overview]
Message-ID: <200804152215.34904.bzolnier@gmail.com> (raw)
In-Reply-To: <20080414175344.GA15028@uranus.ravnborg.org>
On Monday 14 April 2008, Sam Ravnborg wrote:
> On Mon, Apr 14, 2008 at 05:16:59PM +0300, Adrian Bunk wrote:
> > It's plain wrong for PCMCIA to select HAVE_IDE that implies e.g. the
> > availability of an asm/ide.h
> >
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> >
> > ---
> > 9cdb66112488bc0c6e1d528444d3ba30d5b0487f diff --git a/drivers/pcmcia/Kconfig b/drivers/pcmcia/Kconfig
> > index 8b22281..519b4ff 100644
> > --- a/drivers/pcmcia/Kconfig
> > +++ b/drivers/pcmcia/Kconfig
> > @@ -38,7 +38,6 @@ config PCMCIA_DEBUG
> > config PCMCIA
> > tristate "16-bit PCMCIA support"
> > select CRC32
> > - select HAVE_IDE
> > default y
>
> I did this when introducing HAVE_IDE.
> But I do not recall why and the rationale for removing it
> seems fine to me.
IIRC it was needed for some arm platforms which don't select HAVE_IDE
explicetely but I don't know if this is still the case, pinging Russell.
> So patch looks good - but I have not investigated in detail.
>
> Sam
next prev parent reply other threads:[~2008-04-15 21:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-14 14:16 [2.6 patch] PCMCIA mustn't select HAVE_IDE Adrian Bunk
2008-04-14 14:16 ` Adrian Bunk
2008-04-14 17:53 ` Sam Ravnborg
2008-04-15 20:15 ` Bartlomiej Zolnierkiewicz [this message]
2008-04-15 21:23 ` Adrian Bunk
2008-04-15 21:28 ` Russell King
2008-04-15 21:42 ` Russell King
2008-04-15 21:42 ` Russell King
2008-04-15 21:52 ` Adrian Bunk
2008-04-15 22:03 ` Russell King
2008-04-15 22:10 ` Adrian Bunk
2008-04-15 22:39 ` Russell King
2008-04-15 23:26 ` Bartlomiej Zolnierkiewicz
2008-04-15 23:26 ` Bartlomiej Zolnierkiewicz
2008-04-17 9:37 ` [2.6 patch] ARM: always " Adrian Bunk
2008-04-17 9:59 ` Russell King
2008-04-17 10:48 ` Adrian Bunk
2008-04-17 11:00 ` Russell King
2008-04-17 13:25 ` Adrian Bunk
2008-04-19 11:33 ` Russell King
2008-04-27 18:32 ` Bartlomiej Zolnierkiewicz
2008-04-27 20:29 ` Sam Ravnborg
2008-04-27 21:06 ` Bartlomiej Zolnierkiewicz
2008-04-17 12:38 ` Matthew Wilcox
2008-04-27 17:53 ` Bartlomiej Zolnierkiewicz
2008-04-15 21:26 ` [2.6 patch] PCMCIA mustn't " Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804152215.34904.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=bunk@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=rmk@arm.linux.org.uk \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.