[U-Boot-Users] [PATCH] 85xx: Fix detection of MP cpu spin up

[U-Boot-Users] [PATCH] 85xx: Fix detection of MP cpu spin up

[Kumar Gala]

We were looking at the wrong memory offset to determine of a secondary
cpu had been spun up or not.  Also added a warning message if the
all the secondary cpus we expect don't spin up.

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---

This is a bug fix for 1.3.3.

- k

 cpu/mpc85xx/mp.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/cpu/mpc85xx/mp.c b/cpu/mpc85xx/mp.c
index 7b10fba..e733f7b 100644
--- a/cpu/mpc85xx/mp.c
+++ b/cpu/mpc85xx/mp.c
@@ -154,7 +154,7 @@ static void pq3_mp_up(unsigned long bootpg)
 	while (timeout) {
 		int i;
 		for (i = 1; i < CONFIG_NR_CPUS; i++) {
-			if (table[i * NUM_BOOT_ENTRY])
+			if (table[i * NUM_BOOT_ENTRY + BOOT_ENTRY_ADDR_LOWER])
 				cpu_up_mask |= (1 << i);
 		};

@@ -165,6 +165,10 @@ static void pq3_mp_up(unsigned long bootpg)
 		timeout--;
 	}

+	if (timeout == 0)
+		printf("CPU up timeout. CPU up mask is %x should be %x\n",
+			cpu_up_mask, up);
+
 	/* enable time base@the platform */
 	if (whoami)
 		devdisr |= MPC85xx_DEVDISR_TB1;
-- 
1.5.4.1

[U-Boot-Users] [PATCH] 85xx: Fix detection of MP cpu spin up

[Wolfgang Denk]

In message <Pine.LNX.4.64.0804090420320.17674@blarg.am.freescale.net> you wrote:
> We were looking at the wrong memory offset to determine of a secondary
> cpu had been spun up or not.  Also added a warning message if the
> all the secondary cpus we expect don't spin up.
> 
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>

Andy?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You young'uns. That was *long* before AltaVista,  DejaNews,  or  even
(gasp) the *Web*! In fact, we typed that thread on steam-powered card
punchers, and shipped it around via Pony Express.
            -- Randal Schwartz in <8cwww1cd0d.fsf@gadget.cscaper.com>

[U-Boot-Users] [PATCH] 85xx: Fix detection of MP cpu spin up

[Kumar Gala]

On Apr 17, 2008, at 11:14 PM, Wolfgang Denk wrote:
> In message <Pine.LNX. 
> 4.64.0804090420320.17674 at blarg.am.freescale.net> you wrote:
>> We were looking at the wrong memory offset to determine of a  
>> secondary
>> cpu had been spun up or not.  Also added a warning message if the
>> all the secondary cpus we expect don't spin up.
>>
>> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
>
> Andy?

Already in your tree.  Commit 97b3ecb575a92fa34c1765229dbc06f2b662f139

- k