All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: kvm-devel@lists.sourceforge.net, qemu-devel@nongnu.org
Subject: Re: [PATCH 3/3] Implement linux-aio backend
Date: Fri, 18 Apr 2008 14:46:25 -0300	[thread overview]
Message-ID: <20080418174624.GA23124@dmt> (raw)
In-Reply-To: <4808BBC9.6040502@us.ibm.com>

On Fri, Apr 18, 2008 at 10:18:33AM -0500, Anthony Liguori wrote:
> >Sleeping in the context of vcpu's is extremely bad (eg virtio-block
> >blocks in write() throttling which kills performance). It should wait
> >on IO completions instead (qemu-kvm.c creates a pthread "waitqueue" to
> >resolve that issue).
> >
> >Other than that looks fine to me, will give it a try.
> >  
> 
> FWIW, I'm not getting wonderful results in KVM.  It's hard to tell 
> though because time seems wildly inaccurate (even with kvm clock in the 
> guest).  The time issue appears unrelated to this set of patches.

Oh, you won't get completion signals on the aio eventfd. You might want
to try the select-with-timeout() stuff.

Will submit that with proper signalfd emulation shortly.

WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: kvm-devel@lists.sourceforge.net, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 3/3] Implement linux-aio backend
Date: Fri, 18 Apr 2008 14:46:25 -0300	[thread overview]
Message-ID: <20080418174624.GA23124@dmt> (raw)
In-Reply-To: <4808BBC9.6040502@us.ibm.com>

On Fri, Apr 18, 2008 at 10:18:33AM -0500, Anthony Liguori wrote:
> >Sleeping in the context of vcpu's is extremely bad (eg virtio-block
> >blocks in write() throttling which kills performance). It should wait
> >on IO completions instead (qemu-kvm.c creates a pthread "waitqueue" to
> >resolve that issue).
> >
> >Other than that looks fine to me, will give it a try.
> >  
> 
> FWIW, I'm not getting wonderful results in KVM.  It's hard to tell 
> though because time seems wildly inaccurate (even with kvm clock in the 
> guest).  The time issue appears unrelated to this set of patches.

Oh, you won't get completion signals on the aio eventfd. You might want
to try the select-with-timeout() stuff.

Will submit that with proper signalfd emulation shortly.

  reply	other threads:[~2008-04-18 17:46 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-17 19:26 [PATCH 1/3] Refactor AIO interface to allow other AIO implementations Anthony Liguori
2008-04-17 19:26 ` [Qemu-devel] " Anthony Liguori
2008-04-17 19:26 ` [PATCH 2/3] Split out posix-aio code Anthony Liguori
2008-04-17 19:26   ` [Qemu-devel] " Anthony Liguori
2008-04-17 19:26 ` [PATCH 3/3] Implement linux-aio backend Anthony Liguori
2008-04-17 19:26   ` [Qemu-devel] " Anthony Liguori
2008-04-18 15:09   ` Marcelo Tosatti
2008-04-18 15:09     ` [Qemu-devel] " Marcelo Tosatti
2008-04-18 15:18     ` Anthony Liguori
2008-04-18 15:18       ` [Qemu-devel] " Anthony Liguori
2008-04-18 17:46       ` Marcelo Tosatti [this message]
2008-04-18 17:46         ` Marcelo Tosatti
2008-04-17 19:38 ` [PATCH 1/3] Refactor AIO interface to allow other AIO implementations Daniel P. Berrange
2008-04-17 19:38   ` [Qemu-devel] Re: [kvm-devel] " Daniel P. Berrange
2008-04-17 19:41   ` Anthony Liguori
2008-04-17 19:41     ` [Qemu-devel] " Anthony Liguori
2008-04-17 20:00     ` Daniel P. Berrange
2008-04-17 20:00       ` [Qemu-devel] " Daniel P. Berrange
2008-04-17 20:05       ` Anthony Liguori
2008-04-17 20:05         ` [Qemu-devel] Re: [kvm-devel] " Anthony Liguori
2008-04-18 12:43       ` Jamie Lokier
2008-04-18 12:43         ` [Qemu-devel] " Jamie Lokier
2008-04-18 15:23         ` Anthony Liguori
2008-04-18 15:23           ` [Qemu-devel] " Anthony Liguori
2008-04-18 16:22           ` [Qemu-devel] " Jamie Lokier
2008-04-18 16:22             ` [Qemu-devel] Re: [kvm-devel] " Jamie Lokier
2008-04-18 16:32           ` [Qemu-devel] " Avi Kivity
2008-04-18 16:32             ` [kvm-devel] " Avi Kivity
2008-04-20 15:49             ` Jamie Lokier
2008-04-20 15:49               ` [kvm-devel] " Jamie Lokier
2008-04-20 18:43               ` Avi Kivity
2008-04-20 18:43                 ` [kvm-devel] " Avi Kivity
2008-04-20 23:39                 ` Jamie Lokier
2008-04-20 23:39                   ` [kvm-devel] " Jamie Lokier
2008-04-21  6:39                   ` Avi Kivity
2008-04-21  6:39                     ` [kvm-devel] " Avi Kivity
2008-04-21 12:10                     ` Jamie Lokier
2008-04-21 12:10                       ` [kvm-devel] " Jamie Lokier
2008-04-22  8:10                       ` Avi Kivity
2008-04-22  8:10                         ` [kvm-devel] " Avi Kivity
2008-04-22 14:28                         ` [kvm-devel] " Jamie Lokier
2008-04-22 14:28                           ` [kvm-devel] [Qemu-devel] " Jamie Lokier
2008-04-22 14:53                           ` Anthony Liguori
2008-04-22 14:53                             ` [kvm-devel] " Anthony Liguori
2008-04-22 15:05                             ` [kvm-devel] " Avi Kivity
2008-04-22 15:05                               ` [kvm-devel] [Qemu-devel] " Avi Kivity
2008-04-22 15:23                               ` [kvm-devel] " Jamie Lokier
2008-04-22 15:23                                 ` [kvm-devel] [Qemu-devel] " Jamie Lokier
2008-04-22 15:12                             ` [kvm-devel] " Jamie Lokier
2008-04-22 15:12                               ` [kvm-devel] [Qemu-devel] " Jamie Lokier
2008-04-22 15:03                           ` Avi Kivity
2008-04-22 15:03                             ` [kvm-devel] " Avi Kivity
2008-04-22 15:36                             ` [kvm-devel] " Jamie Lokier
2008-04-22 15:36                               ` [kvm-devel] [Qemu-devel] " Jamie Lokier
2008-05-02 16:37                               ` Antonio Vargas
2008-05-02 17:18                                 ` Jamie Lokier
2008-05-02 17:52                                   ` Anthony Liguori
2008-05-02 18:24                                     ` Jamie Lokier
2008-04-22 15:47                         ` Javier Guerra
2008-04-21  0:31                 ` Javier Guerra Giraldez
2008-04-21  6:41                   ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080418174624.GA23124@dmt \
    --to=mtosatti@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.