All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] GRUB2 does not provide Multiboot Legacy memory map
Date: Sun, 20 Apr 2008 12:12:35 +0200	[thread overview]
Message-ID: <20080420101235.GB16764@thorin> (raw)
In-Reply-To: <5F1F44A7E1F44C4BAD769D5F4F7CE197@JerryPC>

On Sat, Apr 19, 2008 at 04:09:15PM -0600, Julian Salazar wrote:
> Attached is the patch. Since I'm not completely familiar with GRUB2's
> internals, there might be a more efficient way of implementing this.
> 
> Thoughts/improvements?

Thanks for the patch.  It'd be interesting if it was done portably.  The
coreboot (aka LinuxBIOS) target also uses this code, and the memory map is
obtained differently there (see kern/i386/linuxbios/init.c).

At least, it could be #ifdef'ed, although it'd be nice to have something
more ellegant (e.g. an isolated, generic function to probe for memory map
arch-dependantly that arch-independant code can use).

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)



      reply	other threads:[~2008-04-20 10:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-19 21:11 [PATCH] GRUB2 does not provide Multiboot Legacy memory map Julian Salazar
2008-04-19 21:32 ` Thomas Schwinge
2008-04-19 22:09   ` Julian Salazar
2008-04-20 10:12     ` Robert Millan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080420101235.GB16764@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.