All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
	"Randy.Dunlap" <rdunlap@xenotime.net>,
	Peter Zijlstra <peterz@infradead.org>,
	Jonathan Corbet <corbet@lwn.net>
Subject: Re: [DOC PATCH] Remove mention of semaphores from kernel-locking
Date: Mon, 21 Apr 2008 10:54:05 -0600	[thread overview]
Message-ID: <20080421165405.GB20637@parisc-linux.org> (raw)
In-Reply-To: <200804220215.30855.rusty@rustcorp.com.au>

On Tue, Apr 22, 2008 at 02:15:30AM +1000, Rusty Russell wrote:
> >     <title>Three Main Types of Kernel Locks: Spinlocks, Mutexes and
> > Semaphores</title>
> >
> >     <para>
> > -     There are three main types of kernel locks.  The fundamental type
> > +     There are two main types of kernel locks.  The fundamental type
> >       is the spinlock
> >       (<filename class="headerfile">include/asm/spinlock.h</filename>),
> >       which is a very simple single-holder lock: if you can't get the
> 
> Fix title, too?

Heh.  Oops, thanks.

> Thanks for the other fixes too; this document needs some love,

No problem ... I started out augmenting it to discuss semaphores and
mutexes properly and realised I'd totally overloaded this document with
detail.  I'm tempted to rip the RCU pieces out of this document and
create a new one.  What we currently have just doesn't read nicely [1],
but this is a project for another day.

> Acked,
> Rusty.

I'll add your ack.  Thanks!

[1] This seems to be a common problem in Linux's Documentation/ directory
... just _read_ CodingStyle and you can tell which bits are Linus'
(funny, deprecating, suggestions) and which bits were added later
(stern, prescriptive, fascist).  The later bits break the flow of the
document and I find them quite jarring.

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

      reply	other threads:[~2008-04-21 16:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-21 14:52 [DOC PATCH] Remove mention of semaphores from kernel-locking Matthew Wilcox
2008-04-21 16:15 ` Rusty Russell
2008-04-21 16:54   ` Matthew Wilcox [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080421165405.GB20637@parisc-linux.org \
    --to=matthew@wil.cx \
    --cc=corbet@lwn.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=rdunlap@xenotime.net \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.