From: Rusty Russell <rusty@rustcorp.com.au>
To: virtualization@lists.linux-foundation.org
Cc: virtualization@lists.osdl.org, Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [5/6] [VIRTIO] net: Add ethtool ops for SG/GSO
Date: Tue, 22 Apr 2008 05:01:46 +1000 [thread overview]
Message-ID: <200804220501.46945.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20080418032142.GD18071@gondor.apana.org.au>
On Friday 18 April 2008 13:21:42 Herbert Xu wrote:
> +static int virtnet_change_mtu(struct net_device *dev, int mtu)
> +{
> + int max = 65535 - ETH_HLEN;
> +
> + if (mtu > max)
> + return -EINVAL;
> + dev->mtu = mtu;
> + return 0;
> +}
Hi Herbert!
I removed this part; useful for testing, but we need a feature bit for MTU
size in general. And to change it on the fly either requires a reset &
re-init, or some protocol (and feature bit!) for renegotiating MTU.
Cheers,
Rusty.
next prev parent reply other threads:[~2008-04-21 19:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-18 3:12 [0/6] [NET]: virtio SG/TSO patches Herbert Xu
2008-04-18 3:14 ` [1/6] [TUN]: Add GSO support Herbert Xu
2008-04-18 3:15 ` [2/6] [TUN]: Add GSO detection Herbert Xu
2008-04-18 3:17 ` [3/6] [TUN]: Fix GSO mapping Herbert Xu
2008-04-18 3:19 ` [4/6] [KVM] virtio-net: Add SG/GSO support Herbert Xu
2008-04-18 3:21 ` [5/6] [VIRTIO] net: Add ethtool ops for SG/GSO Herbert Xu
2008-04-18 3:24 ` [6/6] [VIRTIO] net: Allow receiving SG packets Herbert Xu
2008-04-18 14:08 ` Rusty Russell
2008-04-18 14:30 ` Herbert Xu
2008-04-21 19:06 ` Rusty Russell
2008-04-21 20:04 ` David Miller
2008-04-22 1:13 ` Herbert Xu
2008-04-22 2:50 ` Rusty Russell
2008-04-22 2:55 ` David Miller
2008-04-21 19:01 ` Rusty Russell [this message]
2008-04-22 1:15 ` [5/6] [VIRTIO] net: Add ethtool ops for SG/GSO Herbert Xu
2008-04-22 2:44 ` Rusty Russell
2008-05-29 10:32 ` [3/6] [TUN]: Fix GSO mapping Mark McLoughlin
2008-05-29 10:38 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804220501.46945.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=herbert@gondor.apana.org.au \
--cc=virtualization@lists.linux-foundation.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.