All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: virtualization@lists.linux-foundation.org
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	virtualization@lists.osdl.org, netdev@vger.kernel.org
Subject: Re: [6/6] [VIRTIO] net: Allow receiving SG packets
Date: Tue, 22 Apr 2008 05:06:16 +1000	[thread overview]
Message-ID: <200804220506.16887.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20080418032427.GE18071@gondor.apana.org.au>

On Friday 18 April 2008 13:24:27 Herbert Xu wrote:
> Finally this patch lets virtio_net receive GSO packets in addition
> to sending them.
...
>  static void try_fill_recv(struct virtnet_info *vi)
>  {
>  	struct sk_buff *skb;
> -	struct scatterlist sg[1+MAX_SKB_FRAGS];
> +	struct scatterlist sg[2+MAX_SKB_FRAGS];
>  	int num, err;

I'm not sure what the right number is here.  Say worst case is header which 
goes over a page boundary then MAX_SKB_FRAGS in the skb, but for some reason 
that already has a +2:

/* To allow 64K frame to be packed as single skb without frag_list */
#define MAX_SKB_FRAGS (65536/PAGE_SIZE + 2)

Unless someone explains, I'll change the xmit sg to 2+MAX_SKB_FRAGS as well.

Thanks,
Rusty.

  parent reply	other threads:[~2008-04-21 19:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-18  3:12 [0/6] [NET]: virtio SG/TSO patches Herbert Xu
2008-04-18  3:14 ` [1/6] [TUN]: Add GSO support Herbert Xu
2008-04-18  3:15   ` [2/6] [TUN]: Add GSO detection Herbert Xu
2008-04-18  3:17     ` [3/6] [TUN]: Fix GSO mapping Herbert Xu
2008-04-18  3:19       ` [4/6] [KVM] virtio-net: Add SG/GSO support Herbert Xu
2008-04-18  3:21         ` [5/6] [VIRTIO] net: Add ethtool ops for SG/GSO Herbert Xu
2008-04-18  3:24           ` [6/6] [VIRTIO] net: Allow receiving SG packets Herbert Xu
2008-04-18 14:08             ` Rusty Russell
2008-04-18 14:30               ` Herbert Xu
2008-04-21 19:06             ` Rusty Russell [this message]
2008-04-21 20:04               ` David Miller
2008-04-22  1:13                 ` Herbert Xu
2008-04-22  2:50                 ` Rusty Russell
2008-04-22  2:55                   ` David Miller
2008-04-21 19:01           ` [5/6] [VIRTIO] net: Add ethtool ops for SG/GSO Rusty Russell
2008-04-22  1:15             ` Herbert Xu
2008-04-22  2:44               ` Rusty Russell
2008-05-29 10:32       ` [3/6] [TUN]: Fix GSO mapping Mark McLoughlin
2008-05-29 10:38         ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200804220506.16887.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=virtualization@lists.osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.