[PATCH] fix typo in net/ipv6/Kconfig

[PATCH] fix typo in net/ipv6/Kconfig

[Michael Beasley]

diff --git a/net/ipv6/Kconfig b/net/ipv6/Kconfig
index eb0b808..56b4d86 100644
--- a/net/ipv6/Kconfig
+++ b/net/ipv6/Kconfig
@@ -172,7 +172,7 @@ config IPV6_SIT
          Tunneling means encapsulating data of one protocol type within
          another protocol and sending it over a channel that understands the
          encapsulating protocol. This driver implements encapsulation of IPv6
-         into IPv4 packets. This is useful if you want to connect two IPv6
+         into IPv4 packets. This is useful if you want to connect to IPv6
          networks over an IPv4-only path.

          Saying M here will produce a module called sit.ko. If unsure, say Y.

Two is used in the wrong context here, as you are connecting to an IPv6 network
over IPv4; not connecting two IPv6 networks to an IPv4 one.

Re: [PATCH] fix typo in net/ipv6/Kconfig

[David Miller]

From: Michael Beasley <youvegotmoxie@gmail.com>
Date: Thu, 24 Apr 2008 06:39:50 -0400

> diff --git a/net/ipv6/Kconfig b/net/ipv6/Kconfig
> index eb0b808..56b4d86 100644
> --- a/net/ipv6/Kconfig
> +++ b/net/ipv6/Kconfig
> @@ -172,7 +172,7 @@ config IPV6_SIT
>           Tunneling means encapsulating data of one protocol type within
>           another protocol and sending it over a channel that understands the
>           encapsulating protocol. This driver implements encapsulation of IPv6
> -         into IPv4 packets. This is useful if you want to connect two IPv6
> +         into IPv4 packets. This is useful if you want to connect to IPv6
>           networks over an IPv4-only path.
> 
>           Saying M here will produce a module called sit.ko. If unsure, say Y.

Your email client corrupted the patch, it has turned tab characters
into spaces.

You should also be sure to post your networking patches to
netdev@vger.kernel.org as that's where the networking developers
listen.

Please also provide a proper Signed-off-by: line for your patch (see
linux/Docuemtnation/SubmittingPatches, section 5).

Thanks.

Re: [PATCH] fix typo in net/ipv6/Kconfig

[Maciej W. Rozycki]

On Thu, 24 Apr 2008, Michael Beasley wrote:

> diff --git a/net/ipv6/Kconfig b/net/ipv6/Kconfig
> index eb0b808..56b4d86 100644
> --- a/net/ipv6/Kconfig
> +++ b/net/ipv6/Kconfig
> @@ -172,7 +172,7 @@ config IPV6_SIT
>           Tunneling means encapsulating data of one protocol type within
>           another protocol and sending it over a channel that understands the
>           encapsulating protocol. This driver implements encapsulation of IPv6
> -         into IPv4 packets. This is useful if you want to connect two IPv6
> +         into IPv4 packets. This is useful if you want to connect to IPv6
>           networks over an IPv4-only path.
> 
>           Saying M here will produce a module called sit.ko. If unsure, say Y.
> 
> Two is used in the wrong context here, as you are connecting to an IPv6 network
> over IPv4; not connecting two IPv6 networks to an IPv4 one.

 NAK.  The text correctly describes the scenario.  You have two IPv6
networks, between which you set up a SIT tunnel which transmits data
between the two networks encapsulated in IPv4 packets.  If you find the
text not self-explanatory, then perhaps the sentence could be rewritten as
follows:

"This is useful if you want to connect two IPv6 networks to each other
over an IPv4-only path."

  Maciej

Re: [PATCH] fix typo in net/ipv6/Kconfig

[David Miller]

From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Sat, 26 Apr 2008 00:58:49 +0100 (BST)

> On Thu, 24 Apr 2008, Michael Beasley wrote:
> 
> > diff --git a/net/ipv6/Kconfig b/net/ipv6/Kconfig
> > index eb0b808..56b4d86 100644
> > --- a/net/ipv6/Kconfig
> > +++ b/net/ipv6/Kconfig
> > @@ -172,7 +172,7 @@ config IPV6_SIT
> >           Tunneling means encapsulating data of one protocol type within
> >           another protocol and sending it over a channel that understands the
> >           encapsulating protocol. This driver implements encapsulation of IPv6
> > -         into IPv4 packets. This is useful if you want to connect two IPv6
> > +         into IPv4 packets. This is useful if you want to connect to IPv6
> >           networks over an IPv4-only path.
> > 
> >           Saying M here will produce a module called sit.ko. If unsure, say Y.
> > 
> > Two is used in the wrong context here, as you are connecting to an IPv6 network
> > over IPv4; not connecting two IPv6 networks to an IPv4 one.
> 
>  NAK.  The text correctly describes the scenario.  You have two IPv6
> networks, between which you set up a SIT tunnel which transmits data
> between the two networks encapsulated in IPv4 packets.  If you find the
> text not self-explanatory, then perhaps the sentence could be rewritten as
> follows:
> 
> "This is useful if you want to connect two IPv6 networks to each other
> over an IPv4-only path."

This patch is already in Linus's tree, someone send me a revert
if they want it changed back.

[PATCH] fix typo in net/ipv6/Kconfig

[Michael Beasley]

From: Michael Beasley <youvegotmoxie@gmail.com>

Two is used in the wrong context here, as you are connecting to an IPv6 network
over IPv4; not connecting two IPv6 networks to an IPv4 one.

Signed-off-by: Michael Beasley <youvegotmoxie@gmail.com>
---

diff --git a/net/ipv6/Kconfig b/net/ipv6/Kconfig
index eb0b808..56b4d86 100644
--- a/net/ipv6/Kconfig
+++ b/net/ipv6/Kconfig
@@ -172,7 +172,7 @@ config IPV6_SIT
 	  Tunneling means encapsulating data of one protocol type within
 	  another protocol and sending it over a channel that understands the
 	  encapsulating protocol. This driver implements encapsulation of IPv6
-	  into IPv4 packets. This is useful if you want to connect two IPv6
+	  into IPv4 packets. This is useful if you want to connect to IPv6
 	  networks over an IPv4-only path.
 
 	  Saying M here will produce a module called sit.ko. If unsure, say Y.

---

Re: [PATCH] fix typo in net/ipv6/Kconfig

[David Miller]

From: Michael Beasley <youvegotmoxie@gmail.com>
Date: Thu, 24 Apr 2008 08:40:09 -0400

> From: Michael Beasley <youvegotmoxie@gmail.com>
> 
> Two is used in the wrong context here, as you are connecting to an IPv6 network
> over IPv4; not connecting two IPv6 networks to an IPv4 one.
> 
> Signed-off-by: Michael Beasley <youvegotmoxie@gmail.com>

Applied, thanks Michael.

Re: [PATCH] fix typo in net/ipv6/Kconfig

[Maciej W. Rozycki]

On Thu, 24 Apr 2008, David Miller wrote:

> From: Michael Beasley <youvegotmoxie@gmail.com>
> Date: Thu, 24 Apr 2008 08:40:09 -0400
> 
> > From: Michael Beasley <youvegotmoxie@gmail.com>
> > 
> > Two is used in the wrong context here, as you are connecting to an IPv6 network
> > over IPv4; not connecting two IPv6 networks to an IPv4 one.
> > 
> > Signed-off-by: Michael Beasley <youvegotmoxie@gmail.com>
> 
> Applied, thanks Michael.

 Please revert, the change is wrong as described in my other mail.

  Maciej

Re: [PATCH] fix typo in net/ipv6/Kconfig

[David Miller]

From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Sat, 26 Apr 2008 00:59:57 +0100 (BST)

> On Thu, 24 Apr 2008, David Miller wrote:
> 
> > From: Michael Beasley <youvegotmoxie@gmail.com>
> > Date: Thu, 24 Apr 2008 08:40:09 -0400
> > 
> > > From: Michael Beasley <youvegotmoxie@gmail.com>
> > > 
> > > Two is used in the wrong context here, as you are connecting to an IPv6 network
> > > over IPv4; not connecting two IPv6 networks to an IPv4 one.
> > > 
> > > Signed-off-by: Michael Beasley <youvegotmoxie@gmail.com>
> > 
> > Applied, thanks Michael.
> 
>  Please revert, the change is wrong as described in my other mail.

Done, thanks.