From: Alex Chiang <achiang@hp.com>
To: "Luck, Tony" <tony.luck@intel.com>,
lenb@kernel.org, linux-ia64@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] ia64: Provide ACPI fixup for /proc/cpuinfo/physical_id
Date: Thu, 24 Apr 2008 12:52:22 -0600 [thread overview]
Message-ID: <20080424185222.GC32553@ldl.fc.hp.com> (raw)
In-Reply-To: <20080424184417.GA32553@ldl.fc.hp.com>
Legacy HP ia64 platforms currently cannot provide
/proc/cpuinfo/physical_id due to legacy SAL/PAL implementations.
However, that physical topology information can be obtained
via ACPI.
Provide an interface that gives ACPI one last chance to provide
physical_id for these legacy platforms. This logic only comes
into play iff:
- ACPI actually provides slot information for the CPU
- we lack a valid socket_id
Otherwise, we don't do anything. Since x86 uses the ACPI processor
driver as well, we provide an empty #define.
Signed-off-by: Alex Chiang <achiang@hp.com>
---
arch/ia64/kernel/topology.c | 7 +++++++
drivers/acpi/processor_core.c | 8 ++++++++
include/asm-ia64/cpu.h | 1 +
include/asm-ia64/topology.h | 1 +
include/asm-x86/topology.h | 2 ++
5 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/arch/ia64/kernel/topology.c b/arch/ia64/kernel/topology.c
index a2484fc..bb584b4 100644
--- a/arch/ia64/kernel/topology.c
+++ b/arch/ia64/kernel/topology.c
@@ -27,6 +27,13 @@
static struct ia64_cpu *sysfs_cpus;
+void ia64_fix_socket_id(int num, u32 slot)
+{
+ if (cpu_data(num)->socket_id == -1)
+ cpu_data(num)->socket_id= slot;
+}
+EXPORT_SYMBOL_GPL(ia64_fix_socket_id);
+
int arch_register_cpu(int num)
{
#if defined (CONFIG_ACPI) && defined (CONFIG_HOTPLUG_CPU)
diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
index a825b43..89578d4 100644
--- a/drivers/acpi/processor_core.c
+++ b/drivers/acpi/processor_core.c
@@ -612,6 +612,14 @@ static int acpi_processor_get_info(struct acpi_processor *pr, unsigned has_uid)
request_region(pr->throttling.address, 6, "ACPI CPU throttle");
}
+ /*
+ * If ACPI describes a slot number for this CPU, we can use it
+ * to fix a broken topology->physical_package_id.
+ */
+ status = acpi_evaluate_object(pr->handle, "_SUN", NULL, &buffer);
+ if (ACPI_SUCCESS(status))
+ arch_fix_phys_package_id(pr->id, object.integer.value);
+
return 0;
}
diff --git a/include/asm-ia64/cpu.h b/include/asm-ia64/cpu.h
index e87fa32..9ba5155 100644
--- a/include/asm-ia64/cpu.h
+++ b/include/asm-ia64/cpu.h
@@ -14,6 +14,7 @@ DECLARE_PER_CPU(struct ia64_cpu, cpu_devices);
DECLARE_PER_CPU(int, cpu_state);
+extern void arch_fix_phys_package_id(int num, u32 slot);
extern int arch_register_cpu(int num);
#ifdef CONFIG_HOTPLUG_CPU
extern void arch_unregister_cpu(int);
diff --git a/include/asm-ia64/topology.h b/include/asm-ia64/topology.h
index f2f72ef..8e68f0f 100644
--- a/include/asm-ia64/topology.h
+++ b/include/asm-ia64/topology.h
@@ -116,6 +116,7 @@ void build_cpu_to_node_map(void);
#define smt_capable() (smp_num_siblings > 1)
#endif
+#define arch_fix_phys_package_id(num, slot) ia64_fix_socket_id(num, slot)
#define pcibus_to_cpumask(bus) (pcibus_to_node(bus) == -1 ? \
CPU_MASK_ALL : \
node_to_cpumask(pcibus_to_node(bus)) \
diff --git a/include/asm-x86/topology.h b/include/asm-x86/topology.h
index 2207326..efa3108 100644
--- a/include/asm-x86/topology.h
+++ b/include/asm-x86/topology.h
@@ -193,6 +193,8 @@ extern cpumask_t cpu_coregroup_map(int cpu);
#define topology_thread_siblings(cpu) (per_cpu(cpu_sibling_map, cpu))
#endif
+#define arch_fix_phys_package_id(num, slot)
+
#ifdef CONFIG_SMP
#define mc_capable() (boot_cpu_data.x86_max_cores > 1)
#define smt_capable() (smp_num_siblings > 1)
--
1.5.3.1.g1e61
WARNING: multiple messages have this Message-ID (diff)
From: Alex Chiang <achiang@hp.com>
To: "Luck, Tony" <tony.luck@intel.com>,
lenb@kernel.org, linux-ia64@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] ia64: Provide ACPI fixup for /proc/cpuinfo/physical_id
Date: Thu, 24 Apr 2008 18:52:22 +0000 [thread overview]
Message-ID: <20080424185222.GC32553@ldl.fc.hp.com> (raw)
In-Reply-To: <20080424184417.GA32553@ldl.fc.hp.com>
Legacy HP ia64 platforms currently cannot provide
/proc/cpuinfo/physical_id due to legacy SAL/PAL implementations.
However, that physical topology information can be obtained
via ACPI.
Provide an interface that gives ACPI one last chance to provide
physical_id for these legacy platforms. This logic only comes
into play iff:
- ACPI actually provides slot information for the CPU
- we lack a valid socket_id
Otherwise, we don't do anything. Since x86 uses the ACPI processor
driver as well, we provide an empty #define.
Signed-off-by: Alex Chiang <achiang@hp.com>
---
arch/ia64/kernel/topology.c | 7 +++++++
drivers/acpi/processor_core.c | 8 ++++++++
include/asm-ia64/cpu.h | 1 +
include/asm-ia64/topology.h | 1 +
include/asm-x86/topology.h | 2 ++
5 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/arch/ia64/kernel/topology.c b/arch/ia64/kernel/topology.c
index a2484fc..bb584b4 100644
--- a/arch/ia64/kernel/topology.c
+++ b/arch/ia64/kernel/topology.c
@@ -27,6 +27,13 @@
static struct ia64_cpu *sysfs_cpus;
+void ia64_fix_socket_id(int num, u32 slot)
+{
+ if (cpu_data(num)->socket_id = -1)
+ cpu_data(num)->socket_id= slot;
+}
+EXPORT_SYMBOL_GPL(ia64_fix_socket_id);
+
int arch_register_cpu(int num)
{
#if defined (CONFIG_ACPI) && defined (CONFIG_HOTPLUG_CPU)
diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
index a825b43..89578d4 100644
--- a/drivers/acpi/processor_core.c
+++ b/drivers/acpi/processor_core.c
@@ -612,6 +612,14 @@ static int acpi_processor_get_info(struct acpi_processor *pr, unsigned has_uid)
request_region(pr->throttling.address, 6, "ACPI CPU throttle");
}
+ /*
+ * If ACPI describes a slot number for this CPU, we can use it
+ * to fix a broken topology->physical_package_id.
+ */
+ status = acpi_evaluate_object(pr->handle, "_SUN", NULL, &buffer);
+ if (ACPI_SUCCESS(status))
+ arch_fix_phys_package_id(pr->id, object.integer.value);
+
return 0;
}
diff --git a/include/asm-ia64/cpu.h b/include/asm-ia64/cpu.h
index e87fa32..9ba5155 100644
--- a/include/asm-ia64/cpu.h
+++ b/include/asm-ia64/cpu.h
@@ -14,6 +14,7 @@ DECLARE_PER_CPU(struct ia64_cpu, cpu_devices);
DECLARE_PER_CPU(int, cpu_state);
+extern void arch_fix_phys_package_id(int num, u32 slot);
extern int arch_register_cpu(int num);
#ifdef CONFIG_HOTPLUG_CPU
extern void arch_unregister_cpu(int);
diff --git a/include/asm-ia64/topology.h b/include/asm-ia64/topology.h
index f2f72ef..8e68f0f 100644
--- a/include/asm-ia64/topology.h
+++ b/include/asm-ia64/topology.h
@@ -116,6 +116,7 @@ void build_cpu_to_node_map(void);
#define smt_capable() (smp_num_siblings > 1)
#endif
+#define arch_fix_phys_package_id(num, slot) ia64_fix_socket_id(num, slot)
#define pcibus_to_cpumask(bus) (pcibus_to_node(bus) = -1 ? \
CPU_MASK_ALL : \
node_to_cpumask(pcibus_to_node(bus)) \
diff --git a/include/asm-x86/topology.h b/include/asm-x86/topology.h
index 2207326..efa3108 100644
--- a/include/asm-x86/topology.h
+++ b/include/asm-x86/topology.h
@@ -193,6 +193,8 @@ extern cpumask_t cpu_coregroup_map(int cpu);
#define topology_thread_siblings(cpu) (per_cpu(cpu_sibling_map, cpu))
#endif
+#define arch_fix_phys_package_id(num, slot)
+
#ifdef CONFIG_SMP
#define mc_capable() (boot_cpu_data.x86_max_cores > 1)
#define smt_capable() (smp_num_siblings > 1)
--
1.5.3.1.g1e61
next prev parent reply other threads:[~2008-04-24 18:52 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-10 22:27 [PATCH, RFC] Create 'slot' sysfs attribute in /sys/devices/system/cpu/cpuN/topology/ Alex Chiang
2008-03-10 22:27 ` [PATCH, RFC] Create 'slot' sysfs attribute in Alex Chiang
2008-03-11 17:31 ` [PATCH, RFC] Create 'slot' sysfs attribute in/sys/devices/system/cpu/cpuN/topology/ Luck, Tony
2008-03-11 17:31 ` Luck, Tony
2008-03-11 17:31 ` Luck, Tony
2008-03-11 17:48 ` Matthew Wilcox
2008-03-11 17:48 ` Matthew Wilcox
2008-03-12 15:45 ` Alex Chiang
2008-03-12 15:45 ` [PATCH, RFC] Create 'slot' sysfs attribute Alex Chiang
2008-03-12 21:42 ` [PATCH, RFC] Create 'slot' sysfs attribute in/sys/devices/system/cpu/cpuN/topology/ Luck, Tony
2008-03-12 21:42 ` Luck, Tony
2008-03-12 21:42 ` Luck, Tony
2008-03-19 23:31 ` Alex Chiang
2008-03-19 23:31 ` [PATCH, RFC] Create 'slot' sysfs attribute Alex Chiang
2008-03-21 23:58 ` [PATCH, RFC] Create 'slot' sysfs attributein/sys/devices/system/cpu/cpuN/topology/ Luck, Tony
2008-03-21 23:58 ` Luck, Tony
2008-03-21 23:58 ` Luck, Tony
2008-03-26 18:59 ` Alex Chiang
2008-03-26 18:59 ` [PATCH, RFC] Create 'slot' sysfs Alex Chiang
2008-04-21 5:24 ` [PATCH, RFC] Create 'slot' sysfs attributein/sys/devices/system/cpu/cpuN/topology/ Alex Chiang
2008-04-21 5:24 ` [PATCH, RFC] Create 'slot' sysfs Alex Chiang
2008-04-21 22:00 ` [PATCH, RFC] Create 'slot' sysfsattributein/sys/devices/system/cpu/cpuN/topology/ Luck, Tony
2008-04-21 22:00 ` Luck, Tony
2008-04-21 22:00 ` Luck, Tony
2008-04-24 18:44 ` Alex Chiang
2008-04-24 18:44 ` [PATCH, RFC] Create 'slot' Alex Chiang
2008-04-24 18:51 ` [PATCH 1/2] ia64: Remove printk noise on unimplemented SAL_PHYSICAL_ID_INFO Alex Chiang
2008-04-24 18:51 ` [PATCH 1/2] ia64: Remove printk noise on unimplemented Alex Chiang
2008-04-24 18:57 ` [PATCH 1/2] ia64: Remove printk noise on unimplemented SAL_PHYSICAL_ID_INFO Alex Chiang
2008-04-24 18:57 ` [PATCH 1/2] ia64: Remove printk noise on unimplemented Alex Chiang
2008-04-24 18:52 ` Alex Chiang [this message]
2008-04-24 18:52 ` [PATCH 2/2] ia64: Provide ACPI fixup for /proc/cpuinfo/physical_id Alex Chiang
2008-04-24 18:57 ` Alex Chiang
2008-04-24 18:57 ` [PATCH 2/2] ia64: Provide ACPI fixup for Alex Chiang
2008-04-29 22:32 ` [PATCH 2/2] ia64: Provide ACPI fixup for /proc/cpuinfo/physical_id Luck, Tony
2008-04-29 22:32 ` Luck, Tony
2008-04-29 22:32 ` Luck, Tony
2008-04-29 23:20 ` Alex Chiang
2008-04-29 23:20 ` [PATCH 2/2] ia64: Provide ACPI fixup for Alex Chiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080424185222.GC32553@ldl.fc.hp.com \
--to=achiang@hp.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.