* [PATCH] kbuild: silence documentation GEN xml messages according to $(quiet)
@ 2008-03-24 15:16 Mike Frysinger
2008-03-24 16:09 ` Randy Dunlap
0 siblings, 1 reply; 5+ messages in thread
From: Mike Frysinger @ 2008-03-24 15:16 UTC (permalink / raw)
To: linux-kernel; +Cc: sam
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
Documentation/DocBook/Makefile | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/Documentation/DocBook/Makefile b/Documentation/DocBook/Makefile
index 300e170..f6a4ba3 100644
--- a/Documentation/DocBook/Makefile
+++ b/Documentation/DocBook/Makefile
@@ -186,8 +186,11 @@ quiet_cmd_fig2png = FIG2PNG $@
###
# Rule to convert a .c file to inline XML documentation
+ gen_xml = :
+ quiet_gen_xml = echo ' GEN $@'
+silent_gen_xml = :
%.xml: %.c
- @echo ' GEN $@'
+ @$($(quiet)gen_xml)
@( \
echo "<programlisting>"; \
expand --tabs=8 < $< | \
--
1.5.4.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] kbuild: silence documentation GEN xml messages according to $(quiet)
2008-03-24 15:16 [PATCH] kbuild: silence documentation GEN xml messages according to $(quiet) Mike Frysinger
@ 2008-03-24 16:09 ` Randy Dunlap
2008-03-24 16:57 ` Mike Frysinger
2008-04-25 19:00 ` Sam Ravnborg
0 siblings, 2 replies; 5+ messages in thread
From: Randy Dunlap @ 2008-03-24 16:09 UTC (permalink / raw)
To: Mike Frysinger; +Cc: linux-kernel, sam
On Mon, 24 Mar 2008 11:16:55 -0400 Mike Frysinger wrote:
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> Documentation/DocBook/Makefile | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/DocBook/Makefile b/Documentation/DocBook/Makefile
> index 300e170..f6a4ba3 100644
> --- a/Documentation/DocBook/Makefile
> +++ b/Documentation/DocBook/Makefile
> @@ -186,8 +186,11 @@ quiet_cmd_fig2png = FIG2PNG $@
>
> ###
> # Rule to convert a .c file to inline XML documentation
> + gen_xml = :
> + quiet_gen_xml = echo ' GEN $@'
> +silent_gen_xml = :
> %.xml: %.c
> - @echo ' GEN $@'
> + @$($(quiet)gen_xml)
> @( \
> echo "<programlisting>"; \
> expand --tabs=8 < $< | \
> --
The Makefile changes are good, but the patch description makes it
appear that Mike was rushed. How about something like this?
Add rules for gen_xml and its quiet & silent variants.
This causes "make -s" to be silent for gen_xml.
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
---
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] kbuild: silence documentation GEN xml messages according to $(quiet)
2008-03-24 16:09 ` Randy Dunlap
@ 2008-03-24 16:57 ` Mike Frysinger
2008-04-25 19:00 ` Sam Ravnborg
1 sibling, 0 replies; 5+ messages in thread
From: Mike Frysinger @ 2008-03-24 16:57 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel, sam
[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]
On Monday 24 March 2008, Randy Dunlap wrote:
> On Mon, 24 Mar 2008 11:16:55 -0400 Mike Frysinger wrote:
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> > ---
> > Documentation/DocBook/Makefile | 5 ++++-
> > 1 files changed, 4 insertions(+), 1 deletions(-)
> >
> > diff --git a/Documentation/DocBook/Makefile
> > b/Documentation/DocBook/Makefile index 300e170..f6a4ba3 100644
> > --- a/Documentation/DocBook/Makefile
> > +++ b/Documentation/DocBook/Makefile
> > @@ -186,8 +186,11 @@ quiet_cmd_fig2png = FIG2PNG $@
> >
> > ###
> > # Rule to convert a .c file to inline XML documentation
> > + gen_xml = :
> > + quiet_gen_xml = echo ' GEN $@'
> > +silent_gen_xml = :
> > %.xml: %.c
> > - @echo ' GEN $@'
> > + @$($(quiet)gen_xml)
> > @( \
> > echo "<programlisting>"; \
> > expand --tabs=8 < $< | \
> > --
>
> The Makefile changes are good, but the patch description makes it
> appear that Mike was rushed. How about something like this?
i just copied & pasted the previous commit messages for similar fixes. your
longer version sounds fine to me though.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] kbuild: silence documentation GEN xml messages according to $(quiet)
2008-03-24 16:09 ` Randy Dunlap
2008-03-24 16:57 ` Mike Frysinger
@ 2008-04-25 19:00 ` Sam Ravnborg
2008-04-25 19:20 ` Sam Ravnborg
1 sibling, 1 reply; 5+ messages in thread
From: Sam Ravnborg @ 2008-04-25 19:00 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Mike Frysinger, linux-kernel
On Mon, Mar 24, 2008 at 09:09:39AM -0700, Randy Dunlap wrote:
> On Mon, 24 Mar 2008 11:16:55 -0400 Mike Frysinger wrote:
>
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> > ---
> > Documentation/DocBook/Makefile | 5 ++++-
> > 1 files changed, 4 insertions(+), 1 deletions(-)
> >
> > diff --git a/Documentation/DocBook/Makefile b/Documentation/DocBook/Makefile
> > index 300e170..f6a4ba3 100644
> > --- a/Documentation/DocBook/Makefile
> > +++ b/Documentation/DocBook/Makefile
> > @@ -186,8 +186,11 @@ quiet_cmd_fig2png = FIG2PNG $@
> >
> > ###
> > # Rule to convert a .c file to inline XML documentation
> > + gen_xml = :
> > + quiet_gen_xml = echo ' GEN $@'
> > +silent_gen_xml = :
> > %.xml: %.c
> > - @echo ' GEN $@'
> > + @$($(quiet)gen_xml)
> > @( \
> > echo "<programlisting>"; \
> > expand --tabs=8 < $< | \
> > --
>
> The Makefile changes are good, but the patch description makes it
> appear that Mike was rushed. How about something like this?
>
> Add rules for gen_xml and its quiet & silent variants.
> This causes "make -s" to be silent for gen_xml.
>
> Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
Applied - but I forgot to add this update.
Sorry,
Sam
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] kbuild: silence documentation GEN xml messages according to $(quiet)
2008-04-25 19:00 ` Sam Ravnborg
@ 2008-04-25 19:20 ` Sam Ravnborg
0 siblings, 0 replies; 5+ messages in thread
From: Sam Ravnborg @ 2008-04-25 19:20 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Mike Frysinger, linux-kernel
On Fri, Apr 25, 2008 at 09:00:30PM +0200, Sam Ravnborg wrote:
> On Mon, Mar 24, 2008 at 09:09:39AM -0700, Randy Dunlap wrote:
> > On Mon, 24 Mar 2008 11:16:55 -0400 Mike Frysinger wrote:
> >
> > > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> > > ---
> > > Documentation/DocBook/Makefile | 5 ++++-
> > > 1 files changed, 4 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/Documentation/DocBook/Makefile b/Documentation/DocBook/Makefile
> > > index 300e170..f6a4ba3 100644
> > > --- a/Documentation/DocBook/Makefile
> > > +++ b/Documentation/DocBook/Makefile
> > > @@ -186,8 +186,11 @@ quiet_cmd_fig2png = FIG2PNG $@
> > >
> > > ###
> > > # Rule to convert a .c file to inline XML documentation
> > > + gen_xml = :
> > > + quiet_gen_xml = echo ' GEN $@'
> > > +silent_gen_xml = :
> > > %.xml: %.c
> > > - @echo ' GEN $@'
> > > + @$($(quiet)gen_xml)
> > > @( \
> > > echo "<programlisting>"; \
> > > expand --tabs=8 < $< | \
> > > --
> >
> > The Makefile changes are good, but the patch description makes it
> > appear that Mike was rushed. How about something like this?
> >
> > Add rules for gen_xml and its quiet & silent variants.
> > This causes "make -s" to be silent for gen_xml.
> >
> > Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
> Applied - but I forgot to add this update.
OK - I had not applied the patch so I got it right
in the end. Applied and pushed out.
Sam
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-04-25 19:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-24 15:16 [PATCH] kbuild: silence documentation GEN xml messages according to $(quiet) Mike Frysinger
2008-03-24 16:09 ` Randy Dunlap
2008-03-24 16:57 ` Mike Frysinger
2008-04-25 19:00 ` Sam Ravnborg
2008-04-25 19:20 ` Sam Ravnborg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.