All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robin Holt <holt@sgi.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix file and descriptor handling in perfmon
Date: Sun, 27 Apr 2008 11:51:06 +0000	[thread overview]
Message-ID: <20080427115106.GC19717@sgi.com> (raw)
In-Reply-To: <E1JpvWk-0003lk-FT@ZenIV.linux.org.uk>

Not really an objection, just a simple comment.

On Sun, Apr 27, 2008 at 02:18:02AM +0100, Al Viro wrote:
...
> -static int
> -pfm_alloc_fd(struct file **cfile)
> +static struct file *pfm_alloc_file(pfm_context_t *ctx)

ZZZ
You mangle the style.  Not sure how important that is to Stephane, et
al.  They appear to use a two line function name which does make
searching with vi easier because /^pfm_alloc_file finds the function.

Thanks,
Robin Holt

WARNING: multiple messages have this Message-ID (diff)
From: Robin Holt <holt@sgi.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix file and descriptor handling in perfmon
Date: Sun, 27 Apr 2008 06:51:06 -0500	[thread overview]
Message-ID: <20080427115106.GC19717@sgi.com> (raw)
In-Reply-To: <E1JpvWk-0003lk-FT@ZenIV.linux.org.uk>

Not really an objection, just a simple comment.

On Sun, Apr 27, 2008 at 02:18:02AM +0100, Al Viro wrote:
...
> -static int
> -pfm_alloc_fd(struct file **cfile)
> +static struct file *pfm_alloc_file(pfm_context_t *ctx)

ZZZ
You mangle the style.  Not sure how important that is to Stephane, et
al.  They appear to use a two line function name which does make
searching with vi easier because /^pfm_alloc_file finds the function.

Thanks,
Robin Holt

  reply	other threads:[~2008-04-27 11:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-27  1:18 [PATCH] fix file and descriptor handling in perfmon Al Viro
2008-04-27  1:18 ` Al Viro
2008-04-27 11:51 ` Robin Holt [this message]
2008-04-27 11:51   ` Robin Holt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080427115106.GC19717@sgi.com \
    --to=holt@sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.