From: David Brownell <david-b@pacbell.net>
To: Zhang Rui <rui.zhang@intel.com>
Cc: Zhao Yakui <yakui.zhao@intel.com>,
linux-acpi@vger.kernel.org, linux-pm@lists.linux-foundation.org,
Thomas Renninger <trenn@suse.de>
Subject: Re: [RESEND patch 2.6.25] ACPI uses device_may_wakeup() policy inputs
Date: Mon, 28 Apr 2008 15:28:14 -0700 [thread overview]
Message-ID: <200804281528.14629.david-b@pacbell.net> (raw)
In-Reply-To: <1209372607.3538.107.camel@rzhang-crestline.sh.intel.com>
On Monday 28 April 2008, Zhang Rui wrote:
> > >
> > Yes. What your said is right. If your patch is applied, whether the PCI
> > device can wake the sleeping system is controlled by device driver.
>
> This may cause some "regressions", something like system resumes
> immediately after enter S3. This should rather be a driver/device
> problem which rises a wake up event when it's suspend.
> The right thing to do is to disable the wake up flag for this device.
> The patch was dropped for this reason last time it's merged and we
> should take good care of it this time. :)
>
> Dave,
> Maybe we should state this in the change log?
I already seem to have added that in the changelog for the last
version of the patch I sent ...
- dave
next prev parent reply other threads:[~2008-04-28 22:28 UTC|newest]
Thread overview: 111+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-20 21:08 [patch 2.6.25-rc6 0/7] misc pm wake patches David Brownell
2008-03-20 21:09 ` [patch 2.6.25-rc6 1/7] crosslink ACPI and "real" device nodes David Brownell
2008-03-21 6:43 ` Zhao Yakui
2008-03-21 7:31 ` David Brownell
2008-03-21 8:34 ` Zhao Yakui
2008-03-21 9:04 ` David Brownell
2008-03-21 9:04 ` David Brownell
2008-03-21 8:34 ` Zhao Yakui
2008-03-21 7:31 ` David Brownell
2008-03-21 6:43 ` Zhao Yakui
2008-03-20 21:09 ` David Brownell
2008-03-20 21:10 ` [patch 2.6.25-rc6 2/7] acpi_pm_device_sleep_state() cleanup David Brownell
2008-03-24 16:30 ` [linux-pm] " Pavel Machek
2008-03-24 16:30 ` Pavel Machek
2008-04-19 4:11 ` [RESEND patch 2.6.25] " David Brownell
2008-04-29 20:33 ` [RE-RESEND patch 2.6.25-git] " David Brownell
2008-04-29 20:33 ` David Brownell
2008-04-29 21:49 ` Rafael J. Wysocki
2008-04-29 21:49 ` Rafael J. Wysocki
2008-04-29 22:12 ` David Brownell
2008-04-30 12:07 ` Rafael J. Wysocki
2008-04-30 12:07 ` Rafael J. Wysocki
2008-04-29 22:12 ` David Brownell
2008-03-20 21:10 ` [patch 2.6.25-rc6 2/7] " David Brownell
2008-03-20 21:12 ` [patch 2.6.25-rc6 3/7] pci_choose_state() cleanup and fixes David Brownell
2008-03-20 21:12 ` David Brownell
2008-03-20 22:37 ` Rafael J. Wysocki
2008-03-20 22:37 ` Rafael J. Wysocki
2008-03-20 23:03 ` David Brownell
2008-03-20 23:03 ` David Brownell
2008-03-21 0:22 ` Rafael J. Wysocki
2008-03-21 0:22 ` Rafael J. Wysocki
2008-03-21 0:55 ` [linux-pm] " Alan Stern
2008-03-21 1:47 ` Rafael J. Wysocki
2008-03-21 1:47 ` [linux-pm] " Rafael J. Wysocki
2008-03-21 8:15 ` David Brownell
2008-03-21 16:23 ` Rafael J. Wysocki
2008-03-21 16:23 ` [linux-pm] " Rafael J. Wysocki
2008-03-22 17:55 ` David Brownell
2008-03-22 17:55 ` [linux-pm] " David Brownell
2008-03-22 18:11 ` Rafael J. Wysocki
2008-03-22 18:11 ` [linux-pm] " Rafael J. Wysocki
2008-03-22 18:29 ` David Brownell
2008-03-22 18:29 ` David Brownell
2008-03-21 8:15 ` David Brownell
2008-03-21 0:55 ` Alan Stern
2008-03-21 7:53 ` David Brownell
2008-03-21 16:38 ` Rafael J. Wysocki
2008-03-22 17:49 ` David Brownell
2008-03-22 18:34 ` Rafael J. Wysocki
2008-04-14 4:59 ` David Brownell
2008-04-14 4:59 ` David Brownell
2008-03-22 18:34 ` Rafael J. Wysocki
2008-03-22 17:49 ` David Brownell
2008-03-21 16:38 ` Rafael J. Wysocki
2008-03-21 7:53 ` David Brownell
2008-03-20 21:15 ` [patch 2.6.25-rc6 4/7] USB uses pci_choose_state() David Brownell
2008-03-20 21:15 ` David Brownell
2008-03-20 21:20 ` [patch 2.6.25-rc6 5/7] ACPI sets up device.power.can_wakeup flags David Brownell
2008-03-21 7:43 ` Zhao Yakui
2008-03-21 7:43 ` Zhao Yakui
2008-04-19 4:14 ` [RESEND patch 2.6.25] " David Brownell
2008-04-19 4:14 ` David Brownell
2008-04-22 2:48 ` Zhang Rui
2008-04-22 2:48 ` Zhang Rui
2008-03-20 21:20 ` [patch 2.6.25-rc6 5/7] " David Brownell
2008-03-20 21:22 ` [patch 2.6.25-rc6 6/7] ACPI uses device_may_wakeup() policy inputs David Brownell
2008-03-20 21:22 ` David Brownell
2008-04-19 4:18 ` [RESEND patch 2.6.25] " David Brownell
2008-04-22 2:42 ` Zhang Rui
2008-04-22 2:42 ` Zhang Rui
2008-04-26 19:29 ` David Brownell
2008-04-26 19:29 ` David Brownell
2008-04-22 13:30 ` Zhao Yakui
2008-04-26 19:37 ` David Brownell
2008-04-28 12:48 ` Zhao Yakui
2008-04-28 12:48 ` Zhao Yakui
2008-04-28 8:50 ` Zhang Rui
2008-04-28 8:50 ` Zhang Rui
2008-04-28 13:43 ` [linux-pm] " Alan Stern
2008-04-29 23:38 ` David Brownell
2008-04-30 13:58 ` Alan Stern
2008-05-14 14:56 ` Pavel Machek
2008-05-14 14:56 ` Pavel Machek
2008-04-30 13:58 ` Alan Stern
2008-04-29 23:38 ` David Brownell
2008-04-28 13:43 ` Alan Stern
2008-04-28 22:28 ` David Brownell
2008-04-28 22:28 ` David Brownell [this message]
2008-04-28 21:35 ` Henrique de Moraes Holschuh
2008-04-28 21:35 ` Henrique de Moraes Holschuh
2008-04-28 22:20 ` David Brownell
2008-04-28 22:54 ` Henrique de Moraes Holschuh
2008-04-28 22:54 ` Henrique de Moraes Holschuh
2008-04-29 0:20 ` David Brownell
2008-04-29 0:20 ` David Brownell
2008-04-29 20:32 ` David Brownell
2008-04-29 20:32 ` David Brownell
2008-04-28 22:20 ` David Brownell
2008-04-28 22:24 ` David Brownell
2008-04-28 22:24 ` David Brownell
2008-04-28 22:26 ` David Brownell
2008-04-28 22:26 ` David Brownell
2008-04-26 19:37 ` David Brownell
2008-04-22 13:30 ` Zhao Yakui
2008-03-20 21:25 ` [patch 2.6.25-rc6 7/7] PCI set up device.power.can_wakeup flags David Brownell
2008-03-20 21:53 ` [linux-pm] " Alan Stern
2008-03-20 22:22 ` David Brownell
2008-03-20 22:22 ` [linux-pm] " David Brownell
2008-03-20 21:53 ` Alan Stern
2008-03-20 21:25 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804281528.14629.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rui.zhang@intel.com \
--cc=trenn@suse.de \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.