All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russ Anderson <rja@sgi.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Tony Luck <tony.luck@intel.com>,
	Christoph Lameter <clameter@sgi.com>
Subject: Re: [PATCH 0/2] ia64: Migrate data off physical pages with correctable errors
Date: Mon, 28 Apr 2008 20:36:09 +0000	[thread overview]
Message-ID: <20080428203609.GB23847@sgi.com> (raw)
In-Reply-To: <20080428193323.GA14990@parisc-linux.org>

On Mon, Apr 28, 2008 at 01:33:23PM -0600, Matthew Wilcox wrote:
> On Mon, Apr 28, 2008 at 02:22:52PM -0500, Russ Anderson wrote:
> > 	There is always an issue of how agressive the code should be on
> > 	migrating pages.  Should it migrate on the first correctable error,
> > 	or wait for some threshold?  Reasonable people may disagree on the
> > 	threshold and the "right" answer may be hardware specific.  The 
> > 	decision making is confined to the cpe_migrate.c code.  It is
> > 	currently set to migrate on the first correctable error.
> 
> I think the kernel code should do the migration ASAP.  But I think we
> should have a list of 'bad' pages.  We could then have a badram driver
> that userspace can talk to to find out which pages are bad, map those
> pages into a badram process, do various tests on them, and return the
> pages to the pool if they're determined to be 'good'.

Sure.  The bad page list is badpagelist (defined in mca.c).
 
> I could also see badramd having a list of pages found to be bad
> in previous boots and asking the badram driver to take them out of
> circulation early in boot before they've been allocated.

That would be one alternative.  That type functionality would be
useful.  FWIW, some of my testing was on a system with a DIMM with
solid single bits.  It is a row/column problem so several meg of
addresses are effected.  Each boot it would migrate several meg worth
of pages without any problem.  It works surprisingly good.

-- 
Russ Anderson, OS RAS/Partitioning Project Lead  
SGI - Silicon Graphics Inc          rja@sgi.com

WARNING: multiple messages have this Message-ID (diff)
From: Russ Anderson <rja@sgi.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Tony Luck <tony.luck@intel.com>,
	Christoph Lameter <clameter@sgi.com>
Subject: Re: [PATCH 0/2] ia64: Migrate data off physical pages with correctable errors
Date: Mon, 28 Apr 2008 15:36:09 -0500	[thread overview]
Message-ID: <20080428203609.GB23847@sgi.com> (raw)
In-Reply-To: <20080428193323.GA14990@parisc-linux.org>

On Mon, Apr 28, 2008 at 01:33:23PM -0600, Matthew Wilcox wrote:
> On Mon, Apr 28, 2008 at 02:22:52PM -0500, Russ Anderson wrote:
> > 	There is always an issue of how agressive the code should be on
> > 	migrating pages.  Should it migrate on the first correctable error,
> > 	or wait for some threshold?  Reasonable people may disagree on the
> > 	threshold and the "right" answer may be hardware specific.  The 
> > 	decision making is confined to the cpe_migrate.c code.  It is
> > 	currently set to migrate on the first correctable error.
> 
> I think the kernel code should do the migration ASAP.  But I think we
> should have a list of 'bad' pages.  We could then have a badram driver
> that userspace can talk to to find out which pages are bad, map those
> pages into a badram process, do various tests on them, and return the
> pages to the pool if they're determined to be 'good'.

Sure.  The bad page list is badpagelist (defined in mca.c).
 
> I could also see badramd having a list of pages found to be bad
> in previous boots and asking the badram driver to take them out of
> circulation early in boot before they've been allocated.

That would be one alternative.  That type functionality would be
useful.  FWIW, some of my testing was on a system with a DIMM with
solid single bits.  It is a row/column problem so several meg of
addresses are effected.  Each boot it would migrate several meg worth
of pages without any problem.  It works surprisingly good.

-- 
Russ Anderson, OS RAS/Partitioning Project Lead  
SGI - Silicon Graphics Inc          rja@sgi.com

  reply	other threads:[~2008-04-28 20:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-28 19:22 [PATCH 0/2] ia64: Migrate data off physical pages with correctable errors Russ Anderson
2008-04-28 19:22 ` Russ Anderson
2008-04-28 19:33 ` Matthew Wilcox
2008-04-28 19:33   ` Matthew Wilcox
2008-04-28 20:36   ` Russ Anderson [this message]
2008-04-28 20:36     ` Russ Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080428203609.GB23847@sgi.com \
    --to=rja@sgi.com \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=tony.luck@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.