All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarek Poplawski <jarkao2@gmail.com>
To: Patrick McHardy <kaber@trash.net>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH][NET_SCHED] sch_sfq: fix queue limiting while enqueuing
Date: Tue, 29 Apr 2008 22:53:41 +0200	[thread overview]
Message-ID: <20080429205341.GA4356@ami.dom.local> (raw)
In-Reply-To: <20080428145837.GB2870@ami.dom.local>

On Mon, Apr 28, 2008 at 04:58:37PM +0200, Jarek Poplawski wrote:
...
> Yes, a new parameter looks like the safest choice. I'll only have to
> re-think first the possible reason for this strange limit...

  
static inline void sfq_link(struct sfq_sched_data *q, sfq_index x)
{
	sfq_index p, n;
	int d = q->qs[x].qlen + SFQ_DEPTH;
-------------------->^^^^^^^^

	p = d;
	n = q->dep[d].next;
...

So it's really by design! (I don't know why I missed this, and why
it didn't break my lame test...)

Thanks again for stopping this disaster,
Jarek P. 

  reply	other threads:[~2008-04-29 20:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-27 14:22 [PATCH][NET_SCHED] sch_sfq: fix queue limiting while enqueuing Jarek Poplawski
2008-04-27 18:29 ` Patrick McHardy
2008-04-27 20:36   ` Jarek Poplawski
2008-04-28 14:02     ` Patrick McHardy
2008-04-28 14:58       ` Jarek Poplawski
2008-04-29 20:53         ` Jarek Poplawski [this message]
2008-04-30  7:04           ` Jarek Poplawski
2008-04-30  7:12             ` Patrick McHardy
2008-04-28  9:04 ` [PATCH][NET_SCHED] sch_sfq: prevent unnecessary reordering Jarek Poplawski
2008-04-28  9:03   ` David Miller
2008-04-28 14:39     ` Jarek Poplawski
2008-04-28 11:37   ` Andy Furniss
2008-04-28 15:41     ` Jarek Poplawski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080429205341.GA4356@ami.dom.local \
    --to=jarkao2@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.