From: Patrick McHardy <kaber@trash.net>
To: Jarek Poplawski <jarkao2@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH][NET_SCHED] sch_sfq: fix queue limiting while enqueuing
Date: Wed, 30 Apr 2008 09:12:35 +0200 [thread overview]
Message-ID: <48181BE3.6040407@trash.net> (raw)
In-Reply-To: <20080430070414.GA6828@ami.dom.local>
Jarek Poplawski wrote:
> On Tue, Apr 29, 2008 at 10:53:41PM +0200, Jarek Poplawski wrote:
> ...
>> So it's really by design! (I don't know why I missed this, and why
>
> ...Hmm..., actually this is the place:
>
> sfq_enqueue(struct sk_buff *skb, struct Qdisc *sch)
> {
> ...
> x = q->ht[hash];
> if (x == SFQ_DEPTH) {
> q->ht[hash] = x = q->dep[SFQ_DEPTH].next;
> ...
>
> sfq counts on free slot always available here.
IIRC thats why the limit is capped at SFQ_DEPTH - 1.
next prev parent reply other threads:[~2008-04-30 7:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-27 14:22 [PATCH][NET_SCHED] sch_sfq: fix queue limiting while enqueuing Jarek Poplawski
2008-04-27 18:29 ` Patrick McHardy
2008-04-27 20:36 ` Jarek Poplawski
2008-04-28 14:02 ` Patrick McHardy
2008-04-28 14:58 ` Jarek Poplawski
2008-04-29 20:53 ` Jarek Poplawski
2008-04-30 7:04 ` Jarek Poplawski
2008-04-30 7:12 ` Patrick McHardy [this message]
2008-04-28 9:04 ` [PATCH][NET_SCHED] sch_sfq: prevent unnecessary reordering Jarek Poplawski
2008-04-28 9:03 ` David Miller
2008-04-28 14:39 ` Jarek Poplawski
2008-04-28 11:37 ` Andy Furniss
2008-04-28 15:41 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48181BE3.6040407@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.