All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dan Magenheimer" <dan.magenheimer@oracle.com>
To: Jan Beulich <jbeulich@novell.com>
Cc: Ky Srinivasan <KSrinivasan@novell.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Keir Fraser <keir.fraser@eu.citrix.com>,
	KurtGarloff <garloff@suse.de>
Subject: RE: [PATCH] linux/balloon: don't	allow	ballooningdowna domain below a reasonable limit
Date: Wed, 30 Apr 2008 10:04:05 -0600	[thread overview]
Message-ID: <20080430100405828.00000002360@djm-pc> (raw)
In-Reply-To: <48182DE2.76E4.0078.0@novell.com>

Hi Jan --

Thanks for the reply.  I see the comment now... it didn't
find its way into the source.

I will definitely be working on tuning this estimate
as I am working on maximizing the number of domains
that can be run on a system and this is a constraint.
As a quick-and-dirty test, I just divided the result
of your algorithm (on a 512MB domain) by two and the
maximally-ballooned kernel still ran fine (with
86528kB instead of 173056kB).

Could you explain the logic behind your current algorithm?
I understand you are trying to estimate the additional
kernel data structure space with the addition of the
max_pfn computation but don't understand why this
is a good estimator. I also am wondering how you chose
the magic values for x in MB2PAGES(x).  And also if
you have any tests/workloads you might have used to evaluate
the algorithm.

Thanks,
Dan

> -----Original Message-----
> From: Jan Beulich [mailto:jbeulich@novell.com]
> Sent: Wednesday, April 30, 2008 12:29 AM
> To: dan.magenheimer@oracle.com
> Cc: Keir Fraser; xen-devel@lists.xensource.com; Ky Srinivasan;
> KurtGarloff
> Subject: RE: [Xen-devel] [PATCH] linux/balloon: don't allow
> ballooningdowna domain below a reasonable limit
> 
> 
> >>> "Dan Magenheimer" <dan.magenheimer@oracle.com> 29.04.08 20:35 >>>
> >I made some actual measurements of the results of this algorithm
> >(on a RHEL5u1-32bit guest).
> >
> >memory=	Minimum
> >128		 75776kB
> >256		108544kB
> >512		173056kB
> >1024		238592kB
> >
> >This corresponds to expected values in the source comment
> >However, I wonder if the algorithm is probably too
> >conservative for large(r) memory domains.  With
> >a light load (i.e. continuously compiling Xen),
> >memory utilization rarely exceeds 72MB, regardless
> >of the max memory (at least in the above tested values).
> 
> Sure, this was (in different wording) also stated in the comment
> that came with the patch. A more precise estimate would certainly
> be welcome, but I'm afraid is going to come with a much higher
> (complexity) price tag. Unless you have something simple and
> obvious in mind that we simply didn't spot...
> 
> Jan
> 
>

  reply	other threads:[~2008-04-30 16:04 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-04 15:07 [PATCH] linux/balloon: don't allow ballooning down a domain below a reasonable limit Jan Beulich
2008-04-05 21:39 ` Keir Fraser
2008-04-07  7:10   ` [PATCH] linux/balloon: don't allow ballooningdown " Jan Beulich
2008-04-29 18:35     ` Dan Magenheimer
2008-04-30  6:29       ` [PATCH] linux/balloon: don't allow ballooningdowna " Jan Beulich
2008-04-30 16:04         ` Dan Magenheimer [this message]
2008-04-30 23:49           ` Dan Magenheimer
2008-05-01  7:01             ` Keir Fraser
2008-05-01 14:44               ` Dan Magenheimer
2008-05-01 16:36               ` Alan Cox
2008-05-01 16:56                 ` Keir Fraser
2008-05-01 20:05                   ` Alan Cox
2008-05-01 16:59                 ` Dan Magenheimer
2008-05-01 21:18                   ` Keir Fraser
2008-05-01 23:03                     ` Alan Cox
2008-05-01 23:27                       ` Dan Magenheimer
2008-05-02  7:05                         ` Keir Fraser
2008-05-03 13:53                           ` Dan Magenheimer
2008-05-03 14:11                             ` Keir Fraser
2008-05-03 19:27                               ` Dan Magenheimer
2008-05-03 17:32                             ` Mark Williamson
2008-05-03 19:43                               ` Dan Magenheimer
2008-05-12 22:19                             ` [PATCH] linux/balloon: don't allowballooningdowna " Ian Pratt
2008-05-12 23:34                               ` Dan Magenheimer
2008-05-13 10:35                               ` Markus Hochholdinger
  -- strict thread matches above, loose matches on Subject: below --
2008-05-02 19:30 [PATCH] linux/balloon:don't allow ballooningdowna " Jan Beulich
2008-05-02 22:22 ` Dan Magenheimer
2008-05-03 13:24   ` Goswin von Brederlow
2008-05-09 20:38 ` Dan Magenheimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080430100405828.00000002360@djm-pc \
    --to=dan.magenheimer@oracle.com \
    --cc=KSrinivasan@novell.com \
    --cc=garloff@suse.de \
    --cc=jbeulich@novell.com \
    --cc=keir.fraser@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.