From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: Matthew Wilcox <matthew@wil.cx>,
xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] Remove l_flushsema
Date: Wed, 30 Apr 2008 06:58:32 -0400 [thread overview]
Message-ID: <20080430105832.GA20442@infradead.org> (raw)
In-Reply-To: <20080430104125.GM108924158@sgi.com>
On Wed, Apr 30, 2008 at 08:41:25PM +1000, David Chinner wrote:
> The only thing that I'm concerned about here is that this will
> substantially increase the time the l_icloglock is held. This is
> a severely contended lock on large cpu count machines and putting
> the wakeup inside this lock will increase the hold time.
>
> I guess I can address this by adding a new lock for the waitqueue
> in a separate patch set.
waitqueues are loked internally and don't need synchronization. With
a little bit of re-arranging the code the wake_up could probably be
moved out of the critical section.
next prev parent reply other threads:[~2008-04-30 10:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 9:05 [PATCH] Remove l_flushsema Matthew Wilcox
2008-04-30 10:24 ` Matthew Wilcox
2008-04-30 10:41 ` David Chinner
2008-04-30 10:58 ` Christoph Hellwig [this message]
2008-04-30 11:11 ` David Chinner
2008-04-30 11:15 ` Christoph Hellwig
2008-04-30 11:34 ` David Chinner
2008-04-30 11:37 ` Christoph Hellwig
2008-04-30 15:17 ` Matthew Wilcox
2008-05-01 1:19 ` David Chinner
2008-04-30 11:52 ` Matthew Wilcox
2008-04-30 12:14 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080430105832.GA20442@infradead.org \
--to=hch@infradead.org \
--cc=dgc@sgi.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.