From: David Chinner <dgc@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: David Chinner <dgc@sgi.com>, Matthew Wilcox <matthew@wil.cx>,
xfs@oss.sgi.com
Subject: Re: [PATCH] Remove l_flushsema
Date: Wed, 30 Apr 2008 21:34:18 +1000 [thread overview]
Message-ID: <20080430113418.GP108924158@sgi.com> (raw)
In-Reply-To: <20080430111521.GA16571@infradead.org>
On Wed, Apr 30, 2008 at 07:15:21AM -0400, Christoph Hellwig wrote:
> On Wed, Apr 30, 2008 at 09:11:54PM +1000, David Chinner wrote:
> > > waitqueues are loked internally and don't need synchronization. With
> > > a little bit of re-arranging the code the wake_up could probably be
> > > moved out of the critical section.
> >
> > Yeah, I just realised that myself and was about to reply as such....
> >
> > I'll move the wakeup outside the lock.
>
> Below is the version I have now. One of the rare cases where using
> sv_t actually cleans up the code (althoug the whole sv_ family should
> probably loose some arguments).
Yep, much cleaner. Who's signoff goes on this?
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
next prev parent reply other threads:[~2008-04-30 11:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 9:05 [PATCH] Remove l_flushsema Matthew Wilcox
2008-04-30 10:24 ` Matthew Wilcox
2008-04-30 10:41 ` David Chinner
2008-04-30 10:58 ` Christoph Hellwig
2008-04-30 11:11 ` David Chinner
2008-04-30 11:15 ` Christoph Hellwig
2008-04-30 11:34 ` David Chinner [this message]
2008-04-30 11:37 ` Christoph Hellwig
2008-04-30 15:17 ` Matthew Wilcox
2008-05-01 1:19 ` David Chinner
2008-04-30 11:52 ` Matthew Wilcox
2008-04-30 12:14 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080430113418.GP108924158@sgi.com \
--to=dgc@sgi.com \
--cc=hch@infradead.org \
--cc=matthew@wil.cx \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.