All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Gabriel C <nix.or.die@googlemail.com>
Cc: linux-kernel@vger.kernel.org, wim@iguana.be
Subject: Re: [PATCH] iTCO_wdt: ICH9DO support
Date: Wed, 30 Apr 2008 12:46:42 -0700	[thread overview]
Message-ID: <20080430124642.bcba1673.akpm@linux-foundation.org> (raw)
In-Reply-To: <4818B963.7000108@googlemail.com>

On Wed, 30 Apr 2008 20:24:35 +0200
Gabriel C <nix.or.die@googlemail.com> wrote:

> Andrew Morton wrote:
> > On Wed, 30 Apr 2008 16:51:10 +0200
> > Gabriel C <nix.or.die@googlemail.com> wrote:
> > 
> >> -#define DRV_VERSION     "1.02"
> >> -#define DRV_RELDATE     "26-Jul-2007"
> >> +#define DRV_VERSION     "1.03"
> >> +#define DRV_RELDATE     "30-Apr-2008"
> > 
> > lol.  git-watchdog changes these to
> > 
> > #define DRV_VERSION     "1.10"
> > #define DRV_RELDATE     "17-Aug-2007"
> > 
> > Version numbers and dates like this really are pretty pointless.  If you
> > get a report against "v1.10", it just is not useful information.  You still
> > need to ask "what kernel version" to be able to reliably locate the source
> > for the reporter's driver.
> > 
> > 
> > But it's a great way to generate .rej files.
> 
> Really sorry Andrew here the patch without the changes to the driver version.
> 

Is OK, I already fixed it (as you saw).

There's nothing to be sorry about - it's not your fault.  My email can be
summarised down to "Hey, Wim: remove that crap!".


  reply	other threads:[~2008-04-30 19:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-30 14:51 [PATCH] iTCO_wdt: ICH9DO support Gabriel C
2008-04-30 18:15 ` Andrew Morton
2008-04-30 18:24   ` Gabriel C
2008-04-30 19:46     ` Andrew Morton [this message]
2008-05-05 21:04       ` Wim Van Sebroeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080430124642.bcba1673.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nix.or.die@googlemail.com \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.