From: Gabriel C <nix.or.die@googlemail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, wim@iguana.be
Subject: Re: [PATCH] iTCO_wdt: ICH9DO support
Date: Wed, 30 Apr 2008 20:24:35 +0200 [thread overview]
Message-ID: <4818B963.7000108@googlemail.com> (raw)
In-Reply-To: <20080430111508.2dc5b26c.akpm@linux-foundation.org>
Andrew Morton wrote:
> On Wed, 30 Apr 2008 16:51:10 +0200
> Gabriel C <nix.or.die@googlemail.com> wrote:
>
>> -#define DRV_VERSION "1.02"
>> -#define DRV_RELDATE "26-Jul-2007"
>> +#define DRV_VERSION "1.03"
>> +#define DRV_RELDATE "30-Apr-2008"
>
> lol. git-watchdog changes these to
>
> #define DRV_VERSION "1.10"
> #define DRV_RELDATE "17-Aug-2007"
>
> Version numbers and dates like this really are pretty pointless. If you
> get a report against "v1.10", it just is not useful information. You still
> need to ask "what kernel version" to be able to reliably locate the source
> for the reporter's driver.
>
>
> But it's a great way to generate .rej files.
Really sorry Andrew here the patch without the changes to the driver version.
--
This patch adds the Intel ICH9DO controller ID's for
the iTCO_wdt kernel driver.
Tested on an P5E-VM DO ASUS motherboard.
Signed-off-by: Gabriel Craciunescu <nix.or.die@googlemail.com>
---
drivers/watchdog/iTCO_wdt.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c
index a0e6809..7d3203a 100644
--- a/drivers/watchdog/iTCO_wdt.c
+++ b/drivers/watchdog/iTCO_wdt.c
@@ -44,6 +44,7 @@
* 82801IB (ICH9) : document number 316972-001, 316973-001,
* 82801IR (ICH9R) : document number 316972-001, 316973-001,
* 82801IH (ICH9DH) : document number 316972-001, 316973-001,
+ * 82801IO (ICH9DO) : document number 316972-001, 316973-006,
* 6300ESB (6300ESB) : document number 300641-003, 300884-010,
* 631xESB (631xESB) : document number 313082-001, 313075-005,
* 632xESB (632xESB) : document number 313082-001, 313075-005
@@ -104,6 +105,7 @@ enum iTCO_chipsets {
TCO_ICH9, /* ICH9 */
TCO_ICH9R, /* ICH9R */
TCO_ICH9DH, /* ICH9DH */
+ TCO_ICH9DO, /* ICH9DO */
TCO_631XESB, /* 631xESB/632xESB */
};
@@ -136,6 +138,7 @@ static struct {
{"ICH9", 2},
{"ICH9R", 2},
{"ICH9DH", 2},
+ {"ICH9DO", 2},
{"631xESB/632xESB", 2},
{NULL,0}
};
@@ -181,6 +184,7 @@ static struct pci_device_id iTCO_wdt_pci_tbl[] = {
{ ITCO_PCI_DEVICE(0x2918, TCO_ICH9 )},
{ ITCO_PCI_DEVICE(0x2916, TCO_ICH9R )},
{ ITCO_PCI_DEVICE(PCI_DEVICE_ID_INTEL_ICH9_2, TCO_ICH9DH )},
+ { ITCO_PCI_DEVICE(PCI_DEVICE_ID_INTEL_ICH9_4, TCO_ICH9DO )},
{ ITCO_PCI_DEVICE(PCI_DEVICE_ID_INTEL_ESB2_0, TCO_631XESB)},
{ ITCO_PCI_DEVICE(0x2671, TCO_631XESB)},
{ ITCO_PCI_DEVICE(0x2672, TCO_631XESB)},
next prev parent reply other threads:[~2008-04-30 18:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 14:51 [PATCH] iTCO_wdt: ICH9DO support Gabriel C
2008-04-30 18:15 ` Andrew Morton
2008-04-30 18:24 ` Gabriel C [this message]
2008-04-30 19:46 ` Andrew Morton
2008-05-05 21:04 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4818B963.7000108@googlemail.com \
--to=nix.or.die@googlemail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.