All of lore.kernel.org
 help / color / mirror / Atom feed
* - signals-do_group_exit-use-signal_group_exit-more-consistently.patch removed from -mm tree
@ 2008-05-01  9:25 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2008-05-01  9:25 UTC (permalink / raw)
  To: oleg, roland, mm-commits


The patch titled
     signals: do_group_exit(): use signal_group_exit() more consistently
has been removed from the -mm tree.  Its filename was
     signals-do_group_exit-use-signal_group_exit-more-consistently.patch

This patch was dropped because it was merged into mainline or a subsystem tree

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: signals: do_group_exit(): use signal_group_exit() more consistently
From: Oleg Nesterov <oleg@tv-sign.ru>

do_group_exit() checks SIGNAL_GROUP_EXIT to avoid taking sighand->siglock. 
Since ed5d2cac114202fe2978a9cbcab8f5032796d538 exec() doesn't set this
flag, we should use signal_group_exit().

This is not needed for correctness, but can speedup the multithreaded exec
and makes the code more consistent.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 kernel/exit.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff -puN kernel/exit.c~signals-do_group_exit-use-signal_group_exit-more-consistently kernel/exit.c
--- a/kernel/exit.c~signals-do_group_exit-use-signal_group_exit-more-consistently
+++ a/kernel/exit.c
@@ -1115,12 +1115,13 @@ asmlinkage long sys_exit(int error_code)
 NORET_TYPE void
 do_group_exit(int exit_code)
 {
+	struct signal_struct *sig = current->signal;
+
 	BUG_ON(exit_code & 0x80); /* core dumps don't get here */
 
-	if (current->signal->flags & SIGNAL_GROUP_EXIT)
-		exit_code = current->signal->group_exit_code;
+	if (signal_group_exit(sig))
+		exit_code = sig->group_exit_code;
 	else if (!thread_group_empty(current)) {
-		struct signal_struct *const sig = current->signal;
 		struct sighand_struct *const sighand = current->sighand;
 		spin_lock_irq(&sighand->siglock);
 		if (signal_group_exit(sig))
_

Patches currently in -mm which might be from oleg@tv-sign.ru are

origin.patch
posix-timers-bug-10460-discard-the-pending-signal-when-the-timer-is-destroyed.patch
workqueue-remove-redundant-function-invocation.patch
put_pid-make-sure-we-dont-free-the-live-pid.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-05-01  9:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-01  9:25 - signals-do_group_exit-use-signal_group_exit-more-consistently.patch removed from -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.