From: Rusty Russell <rusty@rustcorp.com.au>
To: Mark McLoughlin <markmc@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio_net: free transmit skbs in a timer
Date: Fri, 2 May 2008 20:55:25 +1000 [thread overview]
Message-ID: <200805022055.25870.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1209565906-9019-1-git-send-email-markmc@redhat.com>
On Thursday 01 May 2008 00:31:46 Mark McLoughlin wrote:
> virtio_net currently only frees old transmit skbs just
> before queueing new ones. If the queue is full, it then
> enables interrupts and waits for notification that more
> work has been performed.
Hi Mark,
This patch is fine, but it's better to do it from skb_xmit_done(). Of
course, this is usually called from an interrupt handler, so it's not
entirely trivial: we can't free the skbs there.
A softirq is probably the answer here, but AFAICT that's old fashioned.
Not sure what the right way of doing this is now...
Rusty.
next prev parent reply other threads:[~2008-05-02 10:56 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 14:31 [PATCH] virtio_net: free transmit skbs in a timer Mark McLoughlin
2008-05-02 10:55 ` Rusty Russell [this message]
2008-05-12 20:37 ` Mark McLoughlin
2008-05-13 7:47 ` Avi Kivity
2008-05-13 7:47 ` Avi Kivity
2008-05-14 6:07 ` Rusty Russell
2008-05-14 6:07 ` Rusty Russell
2008-05-14 8:59 ` Avi Kivity
2008-05-14 8:59 ` Avi Kivity
2008-05-15 15:29 ` Mark McLoughlin
2008-05-15 15:29 ` Mark McLoughlin
2008-05-15 15:32 ` Avi Kivity
2008-05-15 23:25 ` Rusty Russell
2008-05-18 6:40 ` Avi Kivity
2008-05-18 6:40 ` Avi Kivity
2008-05-18 14:16 ` Rusty Russell
2008-05-18 14:16 ` Rusty Russell
2008-05-18 14:27 ` Avi Kivity
2008-05-18 14:27 ` Avi Kivity
2008-05-19 1:52 ` Rusty Russell
2008-05-19 10:26 ` Avi Kivity
2008-05-19 12:21 ` Rusty Russell
2008-05-19 12:21 ` Rusty Russell
2008-05-19 13:26 ` Avi Kivity
2008-05-19 13:26 ` Avi Kivity
2008-05-20 1:37 ` Rusty Russell
2008-05-20 1:37 ` Rusty Russell
2008-05-19 10:26 ` Avi Kivity
2008-05-19 1:52 ` Rusty Russell
2008-05-15 23:25 ` Rusty Russell
2008-05-15 15:32 ` Avi Kivity
2008-05-12 20:37 ` Mark McLoughlin
2008-05-02 10:55 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805022055.25870.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=aliguori@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markmc@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.