From: Avi Kivity <avi@qumranet.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Mark McLoughlin <markmc@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio_net: free transmit skbs in a timer
Date: Sun, 18 May 2008 09:40:05 +0300 [thread overview]
Message-ID: <482FCF45.1050307@qumranet.com> (raw)
In-Reply-To: <200805160925.18087.rusty@rustcorp.com.au>
Rusty Russell wrote:
> On Friday 16 May 2008 01:32:47 Avi Kivity wrote:
>
>> Mark McLoughlin wrote:
>>
>>> I think Rusty is speaking from the POV of the guest driver - i.e. that
>>> virtio_net should never disable notifications on the xmit queue using
>>> disable_cb()?
>>>
>>> Sounds like you think agree, but that the host side should throttle the
>>> rate of xmit notifications?
>>>
>> Yes.
>>
>
> But performance is going to suck in the meantime, as currently our host
> doesn't do this.
>
That's what the feature bits are for.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2008-05-18 6:40 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 14:31 [PATCH] virtio_net: free transmit skbs in a timer Mark McLoughlin
2008-05-02 10:55 ` Rusty Russell
2008-05-02 10:55 ` Rusty Russell
2008-05-12 20:37 ` Mark McLoughlin
2008-05-13 7:47 ` Avi Kivity
2008-05-13 7:47 ` Avi Kivity
2008-05-14 6:07 ` Rusty Russell
2008-05-14 8:59 ` Avi Kivity
2008-05-15 15:29 ` Mark McLoughlin
2008-05-15 15:29 ` Mark McLoughlin
2008-05-15 15:32 ` Avi Kivity
2008-05-15 23:25 ` Rusty Russell
2008-05-18 6:40 ` Avi Kivity
2008-05-18 6:40 ` Avi Kivity [this message]
2008-05-18 14:16 ` Rusty Russell
2008-05-18 14:16 ` Rusty Russell
2008-05-18 14:27 ` Avi Kivity
2008-05-18 14:27 ` Avi Kivity
2008-05-19 1:52 ` Rusty Russell
2008-05-19 1:52 ` Rusty Russell
2008-05-19 10:26 ` Avi Kivity
2008-05-19 10:26 ` Avi Kivity
2008-05-19 12:21 ` Rusty Russell
2008-05-19 12:21 ` Rusty Russell
2008-05-19 13:26 ` Avi Kivity
2008-05-19 13:26 ` Avi Kivity
2008-05-20 1:37 ` Rusty Russell
2008-05-20 1:37 ` Rusty Russell
2008-05-15 23:25 ` Rusty Russell
2008-05-15 15:32 ` Avi Kivity
2008-05-14 8:59 ` Avi Kivity
2008-05-14 6:07 ` Rusty Russell
2008-05-12 20:37 ` Mark McLoughlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482FCF45.1050307@qumranet.com \
--to=avi@qumranet.com \
--cc=aliguori@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markmc@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.