From: Jens Axboe <jens.axboe@oracle.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: akpm@linux-foundation.org, hch@infradead.org,
viro@ZenIV.linux.org.uk, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [patch 15/15] vfs: splice remove_suid() cleanup
Date: Wed, 7 May 2008 09:20:39 +0200 [thread overview]
Message-ID: <20080507072038.GO329@kernel.dk> (raw)
In-Reply-To: <20080505095532.980827078@szeredi.hu>
On Mon, May 05 2008, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@suse.cz>
>
> generic_file_splice_write() duplicates remove_suid() just because it
> doesn't hold i_mutex. But it grabs i_mutex inside splice_from_pipe()
> anyway, so this is rather pointless.
>
> Move locking to generic_file_splice_write() and call remove_suid() and
> __splice_from_pipe() instead.
>
> Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
> CC: Jens Axboe <jens.axboe@oracle.com>
Looks good to me, applied.
--
Jens Axboe
prev parent reply other threads:[~2008-05-07 7:20 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 9:54 [patch 00/15] VFS fixes and cleanups Miklos Szeredi
2008-05-05 9:54 ` [patch 01/15] ecryptfs: clean up (un)lock_parent Miklos Szeredi
2008-05-05 10:59 ` Christoph Hellwig
2008-05-05 9:54 ` [patch 02/15] nfsd: clean up mnt_want_write calls Miklos Szeredi
2008-05-05 10:59 ` Christoph Hellwig
2008-05-05 9:54 ` [patch 03/15] cgroup: dont call vfs_mkdir Miklos Szeredi
2008-05-05 11:00 ` Christoph Hellwig
2008-05-05 12:32 ` Miklos Szeredi
2008-05-05 13:08 ` Christoph Hellwig
2008-05-05 13:29 ` Miklos Szeredi
2008-05-05 13:33 ` Christoph Hellwig
2008-05-05 13:43 ` Miklos Szeredi
2008-05-05 13:46 ` Christoph Hellwig
2008-05-05 13:57 ` Miklos Szeredi
2008-05-05 17:22 ` Paul Menage
2008-05-05 9:54 ` [patch 04/15] reiserfs: dont call vfs_rmdir Miklos Szeredi
2008-05-05 9:54 ` [patch 05/15] reiserfs: dont call notify_change Miklos Szeredi
2008-05-05 9:54 ` [patch 06/15] sysfs: " Miklos Szeredi
2008-05-06 4:15 ` Greg KH
2008-05-06 6:28 ` Miklos Szeredi
2008-05-06 6:48 ` Greg KH
2008-05-05 9:54 ` [patch 07/15] hpfs: " Miklos Szeredi
2008-05-08 0:42 ` Mikulas Patocka
2008-05-05 9:54 ` [patch 08/15] fat: " Miklos Szeredi
2008-05-05 19:45 ` OGAWA Hirofumi
2008-05-06 8:49 ` Miklos Szeredi
2008-05-06 9:27 ` OGAWA Hirofumi
2008-05-05 9:54 ` [patch 09/15] vfs: immutable inode checking cleanup Miklos Szeredi
2008-05-05 11:01 ` Christoph Hellwig
2008-05-05 9:54 ` [patch 10/15] vfs: truncate: dont check immutable twice Miklos Szeredi
2008-05-05 11:04 ` Christoph Hellwig
2008-05-05 9:54 ` [patch 11/15] vfs: truncate: append-only checking cleanup Miklos Szeredi
2008-05-05 11:12 ` Christoph Hellwig
2008-05-05 9:54 ` [patch 12/15] vfs: create file_truncate() helper Miklos Szeredi
2008-05-05 11:06 ` Christoph Hellwig
2008-05-05 12:35 ` Miklos Szeredi
2008-05-05 9:54 ` [patch 13/15] vfs: utimes cleanup Miklos Szeredi
2008-05-05 11:30 ` Christoph Hellwig
2008-05-05 12:39 ` Miklos Szeredi
2008-05-05 13:04 ` Christoph Hellwig
2008-05-05 9:54 ` [patch 14/15] vfs: utimes immutable fix Miklos Szeredi
2008-05-05 11:14 ` Christoph Hellwig
2008-05-05 9:54 ` [patch 15/15] vfs: splice remove_suid() cleanup Miklos Szeredi
2008-05-05 11:11 ` Christoph Hellwig
2008-05-07 7:20 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080507072038.GO329@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.