All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Workaround for the keyboard hang problem in intel mac
Date: Wed, 7 May 2008 14:55:54 +0200	[thread overview]
Message-ID: <20080507125554.GC16492@thorin> (raw)
In-Reply-To: <ca0f59980805061012w7825308cifa52bbcedb5785dd@mail.gmail.com>

On Wed, May 07, 2008 at 01:12:08AM +0800, Bean wrote:
> Hi,
> 
> This patch fix the keyboard hang problem when using boot camp to load
> legacy system.
> 
> diff --git a/kern/i386/pc/startup.S b/kern/i386/pc/startup.S
> index 5d4bbcb..455233a 100644
> --- a/kern/i386/pc/startup.S
> +++ b/kern/i386/pc/startup.S
> @@ -1240,6 +1240,19 @@ FUNCTION(grub_console_getkey)
>  	call	prot_to_real
>  	.code16
> 
> +	pushfw
> +	sti
> +
> +1:
> +	movb	$1, %ah
> +	int	$0x16
> +	jnz	2f
> +	hlt
> +	jmp	1b
> +
> +2:
> +	popfw
> +	movb	$0, %ah

I think it'd be nice to have a comment there explaining why this is done.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)



  reply	other threads:[~2008-05-07 12:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-06 17:12 [PATCH] Workaround for the keyboard hang problem in intel mac Bean
2008-05-07 12:55 ` Robert Millan [this message]
2008-05-07 13:55   ` Bean
2008-05-07 17:09     ` Pavel Roskin
2008-05-07 17:29       ` Bean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080507125554.GC16492@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.