From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: JosephChan@via.com.tw, akpm@linux-foundation.org,
geert@linux-m68k.org, linux-fbdev-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [Linux-fbdev-devel] [PATCH 6/9] viafb: VIA Frame Buffer Device Driver
Date: Wed, 7 May 2008 16:21:18 +0100 [thread overview]
Message-ID: <20080507162118.45ba52bb@core> (raw)
In-Reply-To: <C80EF34A3D2E494DBAF9AC29C7AE4EB806F67759@exchtp03.taipei.via.com.tw>
> +void delays(int count);
> +void i2cWriteSdaScl(u8 sda, u8 scl);
> +void i2cWriteScl(u8 scl);
> +void i2cReadSdaScl(u8 *pSda, u8 *pScl);
Style is good, code looks clean
One big thing that needs fixing here is the function names. If the driver
gets linked into the kernel then the symbols become global - and names
like enableGPIO are asking for clashes. The viafb code is fine as it uses
viafb_ as the function names. Possibly the helper functions should doo
something similar.
We also have a generic i2c layer that might be usable but that is
something that could be addressed in the future and isn't really an
important detail.
>
WARNING: multiple messages have this Message-ID (diff)
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: <JosephChan@via.com.tw>
Cc: <JosephChan@via.com.tw>, <akpm@linux-foundation.org>,
<geert@linux-m68k.org>, <linux-fbdev-devel@lists.sourceforge.net>,
<linux-kernel@vger.kernel.org>
Subject: Re: [Linux-fbdev-devel] [PATCH 6/9] viafb: VIA Frame Buffer Device Driver
Date: Wed, 7 May 2008 16:21:18 +0100 [thread overview]
Message-ID: <20080507162118.45ba52bb@core> (raw)
In-Reply-To: <C80EF34A3D2E494DBAF9AC29C7AE4EB806F67759@exchtp03.taipei.via.com.tw>
> +void delays(int count);
> +void i2cWriteSdaScl(u8 sda, u8 scl);
> +void i2cWriteScl(u8 scl);
> +void i2cReadSdaScl(u8 *pSda, u8 *pScl);
Style is good, code looks clean
One big thing that needs fixing here is the function names. If the driver
gets linked into the kernel then the symbols become global - and names
like enableGPIO are asking for clashes. The viafb code is fine as it uses
viafb_ as the function names. Possibly the helper functions should doo
something similar.
We also have a generic i2c layer that might be usable but that is
something that could be addressed in the future and isn't really an
important detail.
>
next prev parent reply other threads:[~2008-05-07 15:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-07 11:09 [PATCH 6/9] viafb: VIA Frame Buffer Device Driver JosephChan
2008-05-07 11:09 ` [Linux-fbdev-devel] " JosephChan
2008-05-07 15:21 ` Alan Cox [this message]
2008-05-07 15:21 ` Alan Cox
2008-05-08 0:54 ` JosephChan
2008-05-08 0:54 ` [Linux-fbdev-devel] " JosephChan
2008-05-08 7:18 ` Ondrej Zajicek
2008-05-08 7:18 ` [Linux-fbdev-devel] " Ondrej Zajicek
2008-05-08 8:00 ` JosephChan
2008-05-08 8:00 ` [Linux-fbdev-devel] " JosephChan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080507162118.45ba52bb@core \
--to=alan@lxorguk.ukuu.org.uk \
--cc=JosephChan@via.com.tw \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.