From: Ondrej Zajicek <santiago@crfreenet.org>
To: JosephChan@via.com.tw
Cc: linux-fbdev-devel@lists.sourceforge.net,
akpm@linux-foundation.org, geert@linux-m68k.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/9] viafb: VIA Frame Buffer Device Driver
Date: Thu, 8 May 2008 09:58:09 +0200 [thread overview]
Message-ID: <20080508075809.GC11121@localhost.localdomain> (raw)
In-Reply-To: <C80EF34A3D2E494DBAF9AC29C7AE4EB806F67753@exchtp03.taipei.via.com.tw>
On Wed, May 07, 2008 at 07:09:28PM +0800, JosephChan@via.com.tw wrote:
> +u16 red256[] = {
> + 0x0, 0x0, 0x0, 0x0, 0xa800, 0xa800, 0xa800, 0xa800, 0x5400, 0x5400,
> + 0x5400, 0x5400, 0xfc00, 0xfc00, 0xfc00, 0xfc00,
...
> +u16 green256[] =
> + { 0x0, 0x0, 0xa800, 0xa800, 0x0, 0x0, 0x5400, 0xa800, 0x5400, 0x5400,
> + 0xfc00, 0xfc00, 0x5400, 0x5400, 0xfc00, 0xfc00,
...
> +};
> +u16 blue256[] =
> + { 0x0, 0xa800, 0x0, 0xa800, 0x0, 0xa800, 0x0, 0xa800, 0x5400, 0xfc00,
> + 0x5400, 0xfc00, 0x5400, 0xfc00, 0x5400, 0xfc00,
> + 0x0, 0x1400, 0x2000, 0x2c00, 0x3800, 0x4400, 0x5000, 0x6000,
...
> +};
> +
> +struct fb_cmap viafb_256_colors = { 0, 256, red256, green256, blue256, NULL
Standard pattern is to allocate colormap using fb_alloc_cmap(). This function
also fills colormap with common default colormap. It is unnecessary to have
another default colormap.
--
Elen sila lumenn' omentielvo
Ondrej 'SanTiago' Zajicek (email: santiago@crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
WARNING: multiple messages have this Message-ID (diff)
From: Ondrej Zajicek <santiago@crfreenet.org>
To: JosephChan@via.com.tw
Cc: akpm@linux-foundation.org, geert@linux-m68k.org,
linux-fbdev-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [Linux-fbdev-devel] [PATCH 2/9] viafb: VIA Frame Buffer Device Driver
Date: Thu, 8 May 2008 09:58:09 +0200 [thread overview]
Message-ID: <20080508075809.GC11121@localhost.localdomain> (raw)
In-Reply-To: <C80EF34A3D2E494DBAF9AC29C7AE4EB806F67753@exchtp03.taipei.via.com.tw>
On Wed, May 07, 2008 at 07:09:28PM +0800, JosephChan@via.com.tw wrote:
> +u16 red256[] = {
> + 0x0, 0x0, 0x0, 0x0, 0xa800, 0xa800, 0xa800, 0xa800, 0x5400, 0x5400,
> + 0x5400, 0x5400, 0xfc00, 0xfc00, 0xfc00, 0xfc00,
...
> +u16 green256[] =
> + { 0x0, 0x0, 0xa800, 0xa800, 0x0, 0x0, 0x5400, 0xa800, 0x5400, 0x5400,
> + 0xfc00, 0xfc00, 0x5400, 0x5400, 0xfc00, 0xfc00,
...
> +};
> +u16 blue256[] =
> + { 0x0, 0xa800, 0x0, 0xa800, 0x0, 0xa800, 0x0, 0xa800, 0x5400, 0xfc00,
> + 0x5400, 0xfc00, 0x5400, 0xfc00, 0x5400, 0xfc00,
> + 0x0, 0x1400, 0x2000, 0x2c00, 0x3800, 0x4400, 0x5000, 0x6000,
...
> +};
> +
> +struct fb_cmap viafb_256_colors = { 0, 256, red256, green256, blue256, NULL
Standard pattern is to allocate colormap using fb_alloc_cmap(). This function
also fills colormap with common default colormap. It is unnecessary to have
another default colormap.
--
Elen sila lumenn' omentielvo
Ondrej 'SanTiago' Zajicek (email: santiago@crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."
next prev parent reply other threads:[~2008-05-08 7:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-07 11:09 [PATCH 2/9] viafb: VIA Frame Buffer Device Driver JosephChan
2008-05-07 11:09 ` [Linux-fbdev-devel] " JosephChan
2008-05-07 15:30 ` Alan Cox
2008-05-07 15:30 ` Alan Cox
2008-05-08 7:58 ` Ondrej Zajicek [this message]
2008-05-08 7:58 ` Ondrej Zajicek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080508075809.GC11121@localhost.localdomain \
--to=santiago@crfreenet.org \
--cc=JosephChan@via.com.tw \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.