From: Robert Richter <robert.richter@amd.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: stephane eranian <eranian@googlemail.com>,
linux-kernel@vger.kernel.org, ia64 <linux-ia64@vger.kernel.org>
Subject: Re: 2.6.25 new perfmon kernel patch + libpfm + pfmon available
Date: Thu, 08 May 2008 10:11:14 +0000 [thread overview]
Message-ID: <20080508101113.GB3267@erda.amd.com> (raw)
In-Reply-To: <20080429094218.170a349c@infradead.org>
On 29.04.08 09:42:18, Arjan van de Ven wrote:
> On Wed, 30 Apr 2008 15:51:39 +0200
> "stephane eranian" <eranian@googlemail.com> wrote:
>
> > If I recall, AMD said that this special initialization would
> > eventually migrate into the core kernel. The pci_read() may be there
> > because it was not exported by the kernel (this particular code lives
> > in a kernel module).
>
> ... yet your patch adds an EXPORT_SYMBOL() just to make this specific function possible. Weird.
>
> I find it hard to believe that there would be no code in the kernel to
> read or write config space of a device you have..... :)
> In fact I bet 80% of the drivers in the tree use it.
Access to extended config space for AMD northbridges was not yet
implemented. Recent patches from Yinghai Lu fix this. I will send a
patch that uses the in-kernel functions.
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com
WARNING: multiple messages have this Message-ID (diff)
From: Robert Richter <robert.richter@amd.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: stephane eranian <eranian@googlemail.com>,
linux-kernel@vger.kernel.org, ia64 <linux-ia64@vger.kernel.org>
Subject: Re: 2.6.25 new perfmon kernel patch + libpfm + pfmon available
Date: Thu, 8 May 2008 12:11:14 +0200 [thread overview]
Message-ID: <20080508101113.GB3267@erda.amd.com> (raw)
In-Reply-To: <20080429094218.170a349c@infradead.org>
On 29.04.08 09:42:18, Arjan van de Ven wrote:
> On Wed, 30 Apr 2008 15:51:39 +0200
> "stephane eranian" <eranian@googlemail.com> wrote:
>
> > If I recall, AMD said that this special initialization would
> > eventually migrate into the core kernel. The pci_read() may be there
> > because it was not exported by the kernel (this particular code lives
> > in a kernel module).
>
> ... yet your patch adds an EXPORT_SYMBOL() just to make this specific function possible. Weird.
>
> I find it hard to believe that there would be no code in the kernel to
> read or write config space of a device you have..... :)
> In fact I bet 80% of the drivers in the tree use it.
Access to extended config space for AMD northbridges was not yet
implemented. Recent patches from Yinghai Lu fix this. I will send a
patch that uses the in-kernel functions.
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com
next prev parent reply other threads:[~2008-05-08 10:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7c86c4470804291446l4693b317ha7ee2382d00e99e6@mail.gmail.com>
2008-04-29 21:47 ` 2.6.25 new perfmon kernel patch + libpfm + pfmon available stephane eranian
2008-04-29 21:47 ` stephane eranian
2008-04-29 15:08 ` Arjan van de Ven
2008-04-29 15:08 ` Arjan van de Ven
2008-04-30 13:11 ` stephane eranian
2008-04-30 13:11 ` stephane eranian
2008-04-29 15:33 ` Arjan van de Ven
2008-04-29 15:33 ` Arjan van de Ven
2008-04-30 13:51 ` stephane eranian
2008-04-30 13:51 ` stephane eranian
2008-04-29 16:42 ` Arjan van de Ven
2008-04-29 16:42 ` Arjan van de Ven
2008-05-08 10:11 ` Robert Richter [this message]
2008-05-08 10:11 ` Robert Richter
2008-06-19 15:50 ` [PATCH 1/2] AMD64: Removing PCI ECS workaround Robert Richter
2008-06-19 15:50 ` [PATCH 2/2] x86: add PCI extended config space access for AMD Barcelona Robert Richter
2008-06-19 15:59 ` Robert Richter
2008-06-27 15:10 ` stephane eranian
2008-06-27 21:35 ` [perfmon2] " William Cohen
2008-06-27 23:07 ` stephane eranian
2008-05-02 16:01 ` 2.6.25 new perfmon kernel patch + libpfm + pfmon available stephane eranian
2008-05-02 16:01 ` stephane eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080508101113.GB3267@erda.amd.com \
--to=robert.richter@amd.com \
--cc=arjan@infradead.org \
--cc=eranian@googlemail.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.