* [PATCH] minios: fix port selection shifts
@ 2008-05-08 10:23 Samuel Thibault
0 siblings, 0 replies; only message in thread
From: Samuel Thibault @ 2008-05-08 10:23 UTC (permalink / raw)
To: xen-devel
minios: fix port selection shifts
Event selectors span unsigned longs, whose size is not always 32 bits.
Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com>
diff -r 4965e711fee8 extras/mini-os/hypervisor.c
--- a/extras/mini-os/hypervisor.c Wed May 07 15:36:32 2008 +0100
+++ b/extras/mini-os/hypervisor.c Thu May 08 11:23:07 2008 +0100
@@ -58,7 +58,7 @@
l2i = __ffs(l2);
l2 &= ~(1 << l2i);
- port = (l1i << 5) + l2i;
+ port = (l1i * (sizeof(unsigned long) * 8)) + l2i;
do_event(port, regs);
}
}
@@ -100,7 +100,8 @@
* a real IO-APIC we 'lose the interrupt edge' if the channel is masked.
*/
if ( synch_test_bit (port, &s->evtchn_pending[0]) &&
- !synch_test_and_set_bit(port>>5, &vcpu_info->evtchn_pending_sel) )
+ !synch_test_and_set_bit(port / (sizeof(unsigned long) * 8),
+ &vcpu_info->evtchn_pending_sel) )
{
vcpu_info->evtchn_upcall_pending = 1;
if ( !vcpu_info->evtchn_upcall_mask )
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-05-08 10:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-08 10:23 [PATCH] minios: fix port selection shifts Samuel Thibault
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.